New APIs were exposed to allow V8 to correctly serialize Boolean, Number and String objects, as well as detect certain native errors as required by the HTML5 Structured Clone algorithm (http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#safe-passing-of-structured-data). SerializedScriptValue should make use of these APIs.
Created attachment 102188 [details] Changes to SerializedScriptValue + window-postmessage-clone.
Comment on attachment 102188 [details] Changes to SerializedScriptValue + window-postmessage-clone. View in context: https://bugs.webkit.org/attachment.cgi?id=102188&action=review Just a few minor things to clean up. Thanks! > LayoutTests/ChangeLog:14 > + (): Either fix this by adding a function name or remove it. > LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js:224 > + 'return [t1,t1,t2,f1,f1,f2]' put spaces after commas > LayoutTests/fast/dom/Window/window-postmessage-clone-expected.txt:6 > +FAIL: 'postMessage(var x = 0; try { eval("badref"); } catch(e) { x = e; } x)' should throw but didn't We should file a bug for these failures for SquirellFish.
Created attachment 102198 [details] Address comments.
(In reply to comment #3) > Created an attachment (id=102198) [details] > Address comments. Filed a bug for the JSC bindings at https://bugs.webkit.org/show_bug.cgi?id=65292 .
Comment on attachment 102198 [details] Address comments. Attachment 102198 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9265064 New failing tests: fast/loader/stateobjects/pushstate-object-types.html
Created attachment 102271 [details] Fix a broken expectation The test failure above came from an expectation that Error objects could be serialized. In the new revision of the standard this is no longer the case.
Comment on attachment 102271 [details] Fix a broken expectation Clearing flags on attachment: 102271 Committed r91959: <http://trac.webkit.org/changeset/91959>
All reviewed patches have been landed. Closing bug.