Bug 65270 - Load delegate not consulted before loading some poster images
Summary: Load delegate not consulted before loading some poster images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-07-27 11:29 PDT by Eric Carlson
Modified: 2011-07-29 14:31 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch. (5.04 KB, patch)
2011-07-27 14:00 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Proposed patch. (1.31 KB, patch)
2011-07-28 12:11 PDT, Eric Carlson
joepeck: review+
Details | Formatted Diff | Diff
Updated patch (1.63 KB, patch)
2011-07-29 14:18 PDT, Eric Carlson
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-07-27 11:29:12 PDT
The resource load delegate does not get a chance to block a poster image loaded directly by a media engine.
Comment 1 Eric Carlson 2011-07-27 11:29:23 PDT
rdar://8904358
Comment 2 Eric Carlson 2011-07-27 14:00:35 PDT
Created attachment 102180 [details]
Proposed patch.
Comment 3 Eric Carlson 2011-07-27 15:01:30 PDT
http://trac.webkit.org/changeset/91872
Comment 4 Eric Carlson 2011-07-28 11:46:03 PDT
Reopening as r65270 causes an assert in a debug build with a media engine that supports poster loading.
Comment 5 Eric Carlson 2011-07-28 12:11:10 PDT
Created attachment 102283 [details]
Proposed patch.
Comment 6 Joseph Pecoraro 2011-07-29 12:51:01 PDT
Comment on attachment 102283 [details]
Proposed patch.

r=me thanks!
Comment 7 Joseph Pecoraro 2011-07-29 13:06:25 PDT
Comment on attachment 102283 [details]
Proposed patch.

I assume you don't need to set the empty poster url on the player?
Comment 8 Eric Carlson 2011-07-29 14:16:50 PDT
(In reply to comment #7)
> (From update of attachment 102283 [details])
> I assume you don't need to set the empty poster url on the player?

Excellent point, my patch will prevent the poster from being cleared. Update coming up...
Comment 9 Eric Carlson 2011-07-29 14:18:18 PDT
Created attachment 102395 [details]
Updated patch
Comment 10 Joseph Pecoraro 2011-07-29 14:23:29 PDT
Comment on attachment 102395 [details]
Updated patch

r=me!
Comment 11 Eric Carlson 2011-07-29 14:31:09 PDT
http://trac.webkit.org/changeset/92009