Bug 65262 - [skia] fix clipping of some glyphs on windows
Summary: [skia] fix clipping of some glyphs on windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 09:14 PDT by Mike Reed
Modified: 2011-07-28 09:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.85 KB, patch)
2011-07-27 09:16 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-07-27 09:14:21 PDT
[skia] fix clipping of some glyphs on windows
Comment 1 Mike Reed 2011-07-27 09:16:27 PDT
Created attachment 102149 [details]
Patch
Comment 2 Mike Reed 2011-07-27 09:18:33 PDT
These will be rebaselined after we roll to skia rev. 1960, which fixes some clipping issues.

After that, we can process https://bugs.webkit.org/show_bug.cgi?id=65203
Comment 3 Stephen White 2011-07-27 11:46:36 PDT
Comment on attachment 102149 [details]
Patch

Looks good.  r=me
Comment 4 WebKit Review Bot 2011-07-27 20:56:17 PDT
Comment on attachment 102149 [details]
Patch

Clearing flags on attachment: 102149

Committed r91897: <http://trac.webkit.org/changeset/91897>
Comment 5 WebKit Review Bot 2011-07-27 20:56:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2011-07-27 23:38:15 PDT
This patch broke Chromium Windows (Tests):
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/17090/steps/layout-test/logs/stdio
Comment 7 Ryosuke Niwa 2011-07-27 23:48:47 PDT
Fixed in http://trac.webkit.org/changeset/91912.
Comment 8 Adrienne Walker 2011-07-28 09:15:56 PDT
(In reply to comment #7)
> Fixed in http://trac.webkit.org/changeset/91912.

mreed: Please run new-run-webkit-tests --lint-test-files when making test_expectations updates.