Bug 65250 - WebSocket: Pass the value of useHixie76Protocol flag to WebSocket object
Summary: WebSocket: Pass the value of useHixie76Protocol flag to WebSocket object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks: 65247
  Show dependency tree / graph
 
Reported: 2011-07-27 05:23 PDT by Yuta Kitamura
Modified: 2011-07-28 05:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.74 KB, patch)
2011-07-27 06:35 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-07-27 05:23:29 PDT 
To implement bug 65247, we need to determine the WebSocket protocol used by the WebSocketChannel associated with it.

WebSocket objects may reside in worker threads. WorkerContext does not provide the way to obtain Settings values, thus we need to get the value from WebSocketChannel (which is in the loader thread).
Comment 1 Yuta Kitamura 2011-07-27 06:35:47 PDT 
Created attachment 102141 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-07-27 08:43:08 PDT 
Comment on attachment 102141 [details]
Patch

This looks like a case where a bool is better than an enum, because callers don't use true/false literals, and there is no confusion.
Comment 3 WebKit Review Bot 2011-07-28 05:21:18 PDT 
Comment on attachment 102141 [details]
Patch

Clearing flags on attachment: 102141

Committed r91919: <http://trac.webkit.org/changeset/91919>
Comment 4 WebKit Review Bot 2011-07-28 05:21:23 PDT 
All reviewed patches have been landed.  Closing bug.