Bug 65246 - [Qt][WK2] Clean WKPageLoaderClient
Summary: [Qt][WK2] Clean WKPageLoaderClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-07-27 04:32 PDT by Benjamin Poulain
Modified: 2011-07-27 06:55 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.38 KB, patch)
2011-07-27 04:38 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-07-27 04:32:42 PDT
WKPageLoaderClient has empty functions after the refactorings, let's clean that.
Comment 1 Benjamin Poulain 2011-07-27 04:38:50 PDT
Created attachment 102124 [details]
Patch
Comment 2 Andreas Kling 2011-07-27 04:54:54 PDT
Comment on attachment 102124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102124&action=review

r=me

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:116
> +    QUrl qUrl = urlStr;
> +    toQtWebPageProxy(clientInfo)->updateNavigationActions();
> +    toQtWebPageProxy(clientInfo)->didChangeUrl(qUrl);

I don't really see the need for the qUrl variable here.
Comment 3 Benjamin Poulain 2011-07-27 06:12:44 PDT
Comment on attachment 102124 [details]
Patch

This qUrl is just adding clarity, no arm here :)
Comment 4 Andreas Kling 2011-07-27 06:29:24 PDT
(In reply to comment #3)
> (From update of attachment 102124 [details])
> This qUrl is just adding clarity, no arm here :)

If you hinsist :)
Comment 5 WebKit Review Bot 2011-07-27 06:55:20 PDT
Comment on attachment 102124 [details]
Patch

Clearing flags on attachment: 102124

Committed r91840: <http://trac.webkit.org/changeset/91840>
Comment 6 WebKit Review Bot 2011-07-27 06:55:24 PDT
All reviewed patches have been landed.  Closing bug.