Bug 65245 - Rebaseline chromium-win pixel tests for file upload controls
Summary: Rebaseline chromium-win pixel tests for file upload controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 04:20 PDT by dubroy
Modified: 2011-07-28 05:07 PDT (History)
2 users (show)

See Also:

Attachments
Rebaseline tests. (77.27 KB, patch)
2011-07-27 04:21 PDT, dubroy 		no flags Details | Formatted Diff | Diff
Add missing bug URL to Changelog. (77.32 KB, patch)
2011-07-27 04:29 PDT, dubroy 		no flags Details | Formatted Diff | Diff
Format ChangeLog properly. (77.32 KB, patch)
2011-07-27 05:04 PDT, dubroy 		dglazkov: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Merged with trunk. (77.35 KB, patch)
2011-07-28 04:00 PDT, dubroy 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dubroy 2011-07-27 04:20:18 PDT 
r91759 changed the appearance of file upload controls on gtk, chromium-win and chromium-linux. New baselines were already committed for chromium-linux (same changeset) and gtk (r91759). Still need to commit new baselines for chromium-win.
Comment 1 dubroy 2011-07-27 04:21:34 PDT 
Created attachment 102120 [details]
Rebaseline tests.
Comment 2 WebKit Review Bot 2011-07-27 04:23:09 PDT 
Attachment 102120 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 dubroy 2011-07-27 04:29:05 PDT 
Created attachment 102123 [details]
Add missing bug URL to Changelog.
Comment 4 dubroy 2011-07-27 04:44:40 PDT 
Jochen, mind taking a quick look at this?
Comment 5 dubroy 2011-07-27 05:04:41 PDT 
Created attachment 102129 [details]
Format ChangeLog properly.
Comment 6 dubroy 2011-07-27 05:08:20 PDT 
Hi Dimitri,

Can you please review? This is the last of the pixel tests that needed rebaselining due to the change to the file upload controls we landed yesterday.
Comment 7 WebKit Review Bot 2011-07-27 20:26:43 PDT 
Comment on attachment 102129 [details]
Format ChangeLog properly.

Rejecting attachment 102129 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1

Parsed 9 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3917.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/9268010
Comment 8 dubroy 2011-07-28 04:00:00 PDT 
Created attachment 102241 [details]
Merged with trunk.
Comment 9 WebKit Review Bot 2011-07-28 05:07:08 PDT 
Comment on attachment 102241 [details]
Merged with trunk.

Clearing flags on attachment: 102241

Committed r91917: <http://trac.webkit.org/changeset/91917>
Comment 10 WebKit Review Bot 2011-07-28 05:07:14 PDT 
All reviewed patches have been landed.  Closing bug.