RESOLVED FIXED65245
Rebaseline chromium-win pixel tests for file upload controls 
https://bugs.webkit.org/show_bug.cgi?id=65245
Summary Rebaseline chromium-win pixel tests for file upload controls
dubroy
Reported 2011-07-27 04:20:18 PDT
r91759 changed the appearance of file upload controls on gtk, chromium-win and chromium-linux. New baselines were already committed for chromium-linux (same changeset) and gtk (r91759). Still need to commit new baselines for chromium-win.
Attachments
Rebaseline tests. (77.27 KB, patch)
2011-07-27 04:21 PDT, dubroy 		no flags
DetailsFormatted DiffDiff
Add missing bug URL to Changelog. (77.32 KB, patch)
2011-07-27 04:29 PDT, dubroy 		no flags
DetailsFormatted DiffDiff
Format ChangeLog properly. (77.32 KB, patch)
2011-07-27 05:04 PDT, dubroy 		dglazkov: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Merged with trunk. (77.35 KB, patch)
2011-07-28 04:00 PDT, dubroy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
dubroy
Comment 1 2011-07-27 04:21:34 PDT
Created attachment 102120 [details] Rebaseline tests.
WebKit Review Bot
Comment 2 2011-07-27 04:23:09 PDT
Attachment 102120 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
dubroy
Comment 3 2011-07-27 04:29:05 PDT
Created attachment 102123 [details] Add missing bug URL to Changelog.
dubroy
Comment 4 2011-07-27 04:44:40 PDT
Jochen, mind taking a quick look at this?
dubroy
Comment 5 2011-07-27 05:04:41 PDT
Created attachment 102129 [details] Format ChangeLog properly.
dubroy
Comment 6 2011-07-27 05:08:20 PDT
Hi Dimitri, Can you please review? This is the last of the pixel tests that needed rebaselining due to the change to the file upload controls we landed yesterday.
WebKit Review Bot
Comment 7 2011-07-27 20:26:43 PDT
Comment on attachment 102129 [details] Format ChangeLog properly. Rejecting attachment 102129 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: -apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Parsed 9 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3917. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/9268010
dubroy
Comment 8 2011-07-28 04:00:00 PDT
Created attachment 102241 [details] Merged with trunk.
WebKit Review Bot
Comment 9 2011-07-28 05:07:08 PDT
Comment on attachment 102241 [details] Merged with trunk. Clearing flags on attachment: 102241 Committed r91917: <http://trac.webkit.org/changeset/91917>
WebKit Review Bot
Comment 10 2011-07-28 05:07:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.