Bug 65243 - [Qt] Fix tst_QWebElement::render() API test
Summary: [Qt] Fix tst_QWebElement::render() API test
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 38654
  Show dependency treegraph
 
Reported: 2011-07-27 03:34 PDT by Kristóf Kosztyó
Modified: 2014-02-03 03:18 PST (History)
3 users (show)

See Also:


Attachments
mark failing test cases as expected fail (1.95 KB, patch)
2011-08-02 04:41 PDT, Kristóf Kosztyó
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2012-11-14 05:21 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2011-07-27 03:34:53 PDT
FAIL!  : tst_QWebElement::render() 'image1 == testImage' returned FALSE. ()
   Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(988)]
Comment 1 Csaba Osztrogonác 2011-08-02 01:53:13 PDT
Kristóf, could you mark it as expected fail?
Comment 2 Kristóf Kosztyó 2011-08-02 04:41:40 PDT
Created attachment 102632 [details]
mark failing test cases as expected fail 

FAIL! : tst_QWebElement::render() 'image2 == testImage' returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(998)] 
FAIL! : tst_QWebElement::render() 'chunk == image4.copy(chunkPaintRect)' returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp(1035)] 

These testcases also fail
Comment 3 Csaba Osztrogonác 2011-08-02 04:43:04 PDT
Comment on attachment 102632 [details]
mark failing test cases as expected fail 

r=me
Comment 4 Csaba Osztrogonác 2011-08-02 05:14:37 PDT
Comment on attachment 102632 [details]
mark failing test cases as expected fail 

Landed in https://trac.webkit.org/changeset/92179
Comment 5 Csaba Osztrogonác 2012-11-14 05:21:34 PST
Created attachment 174134 [details]
Patch

This part of the testcase passes, but the other two still fail.
Comment 6 Csaba Osztrogonác 2013-03-26 03:57:32 PDT
ping? Don't you want to decrease the number of failing API tests on the bots?
Comment 7 Jocelyn Turcotte 2013-03-26 04:50:13 PDT
Comment on attachment 174134 [details]
Patch

Thanks! rs=me
Comment 8 Csaba Osztrogonác 2013-03-26 05:10:54 PDT
Comment on attachment 174134 [details]
Patch

Clearing flags on attachment: 174134

Committed r146872: <http://trac.webkit.org/changeset/146872>
Comment 9 Csaba Osztrogonác 2013-03-26 05:11:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Csaba Osztrogonác 2013-06-24 05:00:44 PDT
Reopen, because the bug is still valid, only the xfail patch landed.
Comment 11 Jocelyn Turcotte 2014-02-03 03:18:22 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.