Bug 65239 - REGRESSION: [Chromium/782] Speech icon should be on the left side for dir=rtl
Summary: REGRESSION: [Chromium/782] Speech icon should be on the left side for dir=rtl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P1 Major
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 02:20 PDT by Kent Tamura
Modified: 2011-07-27 22:06 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.77 KB, patch)
2011-07-27 02:26 PDT, Kent Tamura
rniwa: review+
tkent: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-07-27 02:20:50 PDT
M13 part of http://code.google.com/p/chromium/issues/detail?id=87045.  M14 and the trunk already have another fix.
Comment 1 Kent Tamura 2011-07-27 02:26:52 PDT
Created attachment 102110 [details]
Patch

*** This is a patch for chromium/782 branch, not the trunk. ***
Comment 2 Kent Tamura 2011-07-27 02:30:26 PDT
I confirmed Chrome 13 with this patch works same as Chrome 12.
 - When I typed "שלום עולם" on www.google.com, the speech button moved to the left side.
 - I clicked on the speech button, then the speech bubble showed on the right side of the search box.
  This is not good, but it's same as Chrome 12.
Comment 3 Ryosuke Niwa 2011-07-27 09:30:36 PDT
Comment on attachment 102110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102110&action=review

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:342
> +                x = borderLeft() + paddingLeft() + (spinBox ? spinBox->width() : 0);

Don't we need to take outerSpinButtonElement into account here?
Comment 4 Kent Tamura 2011-07-27 18:21:09 PDT
Comment on attachment 102110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102110&action=review

>> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:342
>> +                x = borderLeft() + paddingLeft() + (spinBox ? spinBox->width() : 0);
> 
> Don't we need to take outerSpinButtonElement into account here?

In M13, the outer spin button is always located on the right side ;-P
See the code just after this block.
Comment 5 Ryosuke Niwa 2011-07-27 18:26:28 PDT
Comment on attachment 102110 [details]
Patch

(In reply to comment #4)
> In M13, the outer spin button is always located on the right side ;-P
> See the code just after this block.

Okay. r=me then.
Comment 6 Kent Tamura 2011-07-27 22:06:24 PDT
Landed: http://trac.webkit.org/changeset/91904