Bug 65239 – REGRESSION: [Chromium/782] Speech icon should be on the left side for dir=rtl

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

M13 part of http://code.google.com/p/chromium/issues/detail?id=87045.  M14 and the trunk already have another fix.

[Kent Tamura]

Created attachment 102110 [details]
Patch

*** This is a patch for chromium/782 branch, not the trunk. ***

[Kent Tamura]

I confirmed Chrome 13 with this patch works same as Chrome 12.
 - When I typed "שלום עולם" on www.google.com, the speech button moved to the left side.
 - I clicked on the speech button, then the speech bubble showed on the right side of the search box.
  This is not good, but it's same as Chrome 12.

[Ryosuke Niwa]

Comment on attachment 102110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102110&action=review

> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:342
> +                x = borderLeft() + paddingLeft() + (spinBox ? spinBox->width() : 0);

Don't we need to take outerSpinButtonElement into account here?

[Kent Tamura]

Comment on attachment 102110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102110&action=review

>> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:342
>> +                x = borderLeft() + paddingLeft() + (spinBox ? spinBox->width() : 0);
> 
> Don't we need to take outerSpinButtonElement into account here?

In M13, the outer spin button is always located on the right side ;-P
See the code just after this block.

[Ryosuke Niwa]

Comment on attachment 102110 [details]
Patch

(In reply to comment #4)
> In M13, the outer spin button is always located on the right side ;-P
> See the code just after this block.

Okay. r=me then.

[Kent Tamura]

Landed: http://trac.webkit.org/changeset/91904