Bug 65232 - WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
Summary: WebSocket: CloseEvent attribute is not available on WebWorkers in JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 22:28 PDT by Yuta Kitamura
Modified: 2011-07-27 01:57 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.34 KB, patch)
2011-07-26 23:44 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff
Patch v2 (updated ChangeLog) (5.65 KB, patch)
2011-07-27 00:46 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-07-26 22:28:07 PDT
CloseEvent isn't available from WebWorkers in JSC. V8 is not affected.

We should have added [NoStaticTables] attribute in CloseEvent.idl.
Comment 1 Yuta Kitamura 2011-07-26 23:23:44 PDT
What I meant was "closeEvent.wasClean returns undefined in workers." Updated the bug summary.
Comment 2 Yuta Kitamura 2011-07-26 23:44:50 PDT
Created attachment 102096 [details]
Patch
Comment 3 Kent Tamura 2011-07-26 23:55:05 PDT
Comment on attachment 102096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102096&action=review

> Source/WebCore/ChangeLog:8
> +        Add [NoStaticTables] attribute to CloseEvent interface definition.

Would you explain why it fixes the problem please?
Comment 4 Yuta Kitamura 2011-07-27 00:46:09 PDT
Created attachment 102102 [details]
Patch v2 (updated ChangeLog)
Comment 5 Kent Tamura 2011-07-27 00:49:32 PDT
Comment on attachment 102102 [details]
Patch v2 (updated ChangeLog)

Looks ok
Comment 6 WebKit Review Bot 2011-07-27 01:57:12 PDT
Comment on attachment 102102 [details]
Patch v2 (updated ChangeLog)

Clearing flags on attachment: 102102

Committed r91826: <http://trac.webkit.org/changeset/91826>
Comment 7 WebKit Review Bot 2011-07-27 01:57:17 PDT
All reviewed patches have been landed.  Closing bug.