Bug 65226 – REGRESSION(r91805): Breaks @ symbols and changes other font rendering on Windows (Requested by enne on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/91805 broke the build:
Breaks @ symbols and changes other font rendering on Windows (Requested by enne on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 102093 [details]
ROLLOUT of r91805

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Review Bot]

Attachment 102093 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:77:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:77:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/skia/SkiaFontWin.h:45:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:94:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:177:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:212:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:289:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:432:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 8 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 102093 [details]
ROLLOUT of r91805

Clearing flags on attachment: 102093

Committed r91822: <http://trac.webkit.org/changeset/91822>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.