Bug 65226 - REGRESSION(r91805): Breaks @ symbols and changes other font rendering on Windows (Requested by enne on #webkit).
Summary: REGRESSION(r91805): Breaks @ symbols and changes other font rendering on Wind...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 65203
  Show dependency treegraph
 
Reported: 2011-07-26 20:37 PDT by WebKit Review Bot
Modified: 2011-07-26 20:42 PDT (History)
1 user (show)

See Also:


Attachments
ROLLOUT of r91805 (32.07 KB, patch)
2011-07-26 20:37 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-07-26 20:37:29 PDT
http://trac.webkit.org/changeset/91805 broke the build:
Breaks @ symbols and changes other font rendering on Windows (Requested by enne on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-07-26 20:37:57 PDT
Created attachment 102093 [details]
ROLLOUT of r91805

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Review Bot 2011-07-26 20:40:39 PDT
Attachment 102093 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:77:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:77:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/skia/SkiaFontWin.h:45:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:94:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:177:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:212:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:289:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp:432:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 8 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-07-26 20:42:35 PDT
Comment on attachment 102093 [details]
ROLLOUT of r91805

Clearing flags on attachment: 102093

Committed r91822: <http://trac.webkit.org/changeset/91822>
Comment 4 WebKit Review Bot 2011-07-26 20:42:39 PDT
All reviewed patches have been landed.  Closing bug.