Bug 65217 - AudioContext is not correctly accounting for hardware resources
Summary: AudioContext is not correctly accounting for hardware resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 16:04 PDT by Chris Rogers
Modified: 2011-07-26 17:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.19 KB, patch)
2011-07-26 16:13 PDT, Chris Rogers
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-07-26 16:04:03 PDT
AudioContext is not correctly accounting for hardware resources
Comment 1 Chris Rogers 2011-07-26 16:13:52 PDT
Created attachment 102071 [details]
Patch
Comment 2 Chris Rogers 2011-07-26 16:16:35 PDT
It turns out that the global ref-count is only decremented if the AudioContext::lazyInitialize() has been previously called.  So we need to move the increment (and hardware initialization) properly into the lazyInitialize() method...
Comment 3 Kenneth Russell 2011-07-26 16:40:56 PDT
Comment on attachment 102071 [details]
Patch

Looks fine as long as it's been tested.
Comment 4 Chris Rogers 2011-07-26 17:15:48 PDT
Committed r91801: <http://trac.webkit.org/changeset/91801>