Bug 65212 - DFG speculative JIT never emits inline double comparisons, even when it would be obvious more efficient to do so
Summary: DFG speculative JIT never emits inline double comparisons, even when it would...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 15:42 PDT by Filip Pizlo
Modified: 2011-07-26 18:28 PDT (History)
3 users (show)

See Also:

Attachments
the patch (9.47 KB, patch)
2011-07-26 15:47 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-26 15:42:39 PDT 
The DFG speculative JIT gets some of its performance improvement from treating certain numbers as doubles and never as ints.  But comparisons don't take advantage of this, and instead either speculate integer, or perform slow C calls.  The DFG speculative JIT's compare/branch implementations should inline double comparisons if it's obvious that this would be a win, for example if both operands are known to be double.
Comment 1 Filip Pizlo 2011-07-26 15:47:45 PDT 
Created attachment 102066 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-26 18:27:56 PDT 
Comment on attachment 102066 [details]
the patch

Clearing flags on attachment: 102066

Committed r91807: <http://trac.webkit.org/changeset/91807>
Comment 3 WebKit Review Bot 2011-07-26 18:28:01 PDT 
All reviewed patches have been landed.  Closing bug.