Bug 65195 - regression: generating CSSValueKeywords should not print by default
Summary: regression: generating CSSValueKeywords should not print by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Evan Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 11:31 PDT by Evan Martin
Modified: 2011-07-26 12:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2011-07-26 11:32 PDT, Evan Martin 		no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2011-07-26 11:34 PDT, Evan Martin 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2011-07-26 11:31:03 PDT 
regression: generating CSSValueKeywords should not print by default
Comment 1 Evan Martin 2011-07-26 11:32:37 PDT 
Created attachment 102031 [details]
Patch
Comment 2 Evan Martin 2011-07-26 11:34:19 PDT 
Here are all the callers I could find of applyPreprocessor:
http://codesearch.google.com/codesearch#search/&exact_package=chromium&q=applypreprocessor&type=cs

The ones that don't provide a final argument should print nothing; they regressed.
The one that passes 1 as a final argument wants to always be quiet.
So there was only one caller that actually wanted the output.
Comment 3 Evan Martin 2011-07-26 11:34:39 PDT 
Created attachment 102032 [details]
Patch
Comment 4 Tony Chang 2011-07-26 11:37:06 PDT 
Comment on attachment 102032 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102032&action=review

> Source/WebCore/bindings/scripts/IDLParser.pm:70
>      my @documentContent = applyPreprocessor($fileName, $defines, $preprocessor, $beQuiet);

Nit: Remove $beQuiet here.
Comment 5 Evan Martin 2011-07-26 12:13:14 PDT 
Committed r91770: <http://trac.webkit.org/changeset/91770>