RESOLVED FIXED65195
regression: generating CSSValueKeywords should not print by default 
https://bugs.webkit.org/show_bug.cgi?id=65195
Summary regression: generating CSSValueKeywords should not print by default
Evan Martin
Reported 2011-07-26 11:31:03 PDT
regression: generating CSSValueKeywords should not print by default
Attachments
Patch (2.48 KB, patch)
2011-07-26 11:32 PDT, Evan Martin 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2011-07-26 11:34 PDT, Evan Martin 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2011-07-26 11:32:37 PDT
Created attachment 102031 [details] Patch
Evan Martin
Comment 2 2011-07-26 11:34:19 PDT
Here are all the callers I could find of applyPreprocessor: http://codesearch.google.com/codesearch#search/&exact_package=chromium&q=applypreprocessor&type=cs The ones that don't provide a final argument should print nothing; they regressed. The one that passes 1 as a final argument wants to always be quiet. So there was only one caller that actually wanted the output.
Evan Martin
Comment 3 2011-07-26 11:34:39 PDT
Created attachment 102032 [details] Patch
Tony Chang
Comment 4 2011-07-26 11:37:06 PDT
Comment on attachment 102032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102032&action=review > Source/WebCore/bindings/scripts/IDLParser.pm:70 > my @documentContent = applyPreprocessor($fileName, $defines, $preprocessor, $beQuiet); Nit: Remove $beQuiet here.
Evan Martin
Comment 5 2011-07-26 12:13:14 PDT
Committed r91770: <http://trac.webkit.org/changeset/91770>
Note You need to log in before you can comment on or make changes to this bug.