Bug 65190 - Add protection space authentication callback code to CFNetwork loader on Mac
Summary: Add protection space authentication callback code to CFNetwork loader on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on:
Blocks: 51836
  Show dependency treegraph
 
Reported: 2011-07-26 10:12 PDT by Pratik Solanki
Modified: 2011-07-26 16:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.31 KB, patch)
2011-07-26 11:03 PDT, Pratik Solanki
oliver: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-07-26 10:12:00 PDT
Currently, the USE(PROTECTION_SPACE_AUTH_CALLBACK) code is only implemented in ResourceHandleMac.mm. In order to use the CFNetwork based loader on Mac, we need to implement that call back in ResourceHandleCFNet.cpp as well.
Comment 1 Pratik Solanki 2011-07-26 11:02:51 PDT
<rdar://problem/9842424>
Comment 2 Pratik Solanki 2011-07-26 11:03:49 PDT
Created attachment 102025 [details]
Patch
Comment 3 Oliver Hunt 2011-07-26 11:07:43 PDT
Comment on attachment 102025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102025&action=review

r=me, but it would be good to have a bug filed for the FIXME

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:921
> +    // FIXME: We should ask FrameLoaderClient.

Is there a bug filed for this?
Comment 4 Pratik Solanki 2011-07-26 11:11:48 PDT
(In reply to comment #3)
> (From update of attachment 102025 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102025&action=review
> 
> r=me, 

Thanks!

> but it would be good to have a bug filed for the FIXME
> 
> > Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:921
> > +    // FIXME: We should ask FrameLoaderClient.
> 
> Is there a bug filed for this?

It's the same in ResourceHandleMac.mm. We have lots of FIXMEs in the synchronous loader case (in both ResourceHandleCFNet.cpp and ResourceHandleMac.mm). Let me look around to see if we have a bug on that.
Comment 5 Pratik Solanki 2011-07-26 11:39:09 PDT
(In reply to comment #4)
> (In reply to comment #3)

> > Is there a bug filed for this?
> 
> It's the same in ResourceHandleMac.mm. We have lots of FIXMEs in the synchronous loader case (in both ResourceHandleCFNet.cpp and ResourceHandleMac.mm). Let me look around to see if we have a bug on that.

So there's bug 8342 about didReceiveAuthenticationChallenge but I couldn't find any for the protection space callback. Field <https://bugs.webkit.org/show_bug.cgi?id=65196>. I'll put a reference to it in the comments.
Comment 6 WebKit Review Bot 2011-07-26 12:00:24 PDT
Comment on attachment 102025 [details]
Patch

Attachment 102025 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9253371
Comment 7 Pratik Solanki 2011-07-26 13:38:37 PDT
(In reply to comment #6)
> (From update of attachment 102025 [details])
> Attachment 102025 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/9253371

Pretty sure this is because UNUSED_PARAM() should be inside #if LOG_DISABLED, not #if !LOG_DISABLED. If only the EWS bot let me see the full build result.... Will confirm with a release build (since debug doesn't have any problems compiling ResourceHandleMac.mm) and commit.
Comment 8 Pratik Solanki 2011-07-26 16:44:33 PDT
Committed r91799: <http://trac.webkit.org/changeset/91799>