Bug 65189 – [Qt] [WK2] Disable the build with Qt versions older than 5.0

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Andras Becsi]

Because of the transition of QtWebKit2 to the new SceneGraph infrastructure of Qt5 we need to disable the build for Qt versions older than 5.0.

More information on this can be found here http://www.mail-archive.com/[e-mail]/msg01674.html.

[Andras Becsi]

Created attachment 102023 [details]
proposed patch

[Csaba Osztrogonác]

Comment on attachment 102023 [details]
proposed patch

LGTM, r=me.

[WebKit Review Bot]

Comment on attachment 102023 [details]
proposed patch

Rejecting attachment 102023 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9238009

[Andras Becsi]

Comment on attachment 102023 [details]
proposed patch

Clearing flags on attachment: 102023

Committed r91766: <http://trac.webkit.org/changeset/91766>

[Andras Becsi]

All reviewed patches have been landed.  Closing bug.