Bug 65184 - Web Inspector: Disable cache option should only clear memory cache, not disable it.
Summary: Web Inspector: Disable cache option should only clear memory cache, not disab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 07:44 PDT by Vsevolod Vlasov
Modified: 2011-07-27 11:30 PDT (History)
12 users (show)

See Also:


Attachments
Patch (12.58 KB, patch)
2011-07-26 07:49 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (13.56 KB, patch)
2011-07-27 02:42 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-07-26 07:44:07 PDT
Disable cache option should only clear memory cache, not disable it.

Apparently clearing memory cache on reload should be enough for developers.
This will also have less side effects. 
E.g. disabling memory cache causes several willSendRequest calls for some resources.
Comment 1 Vsevolod Vlasov 2011-07-26 07:49:09 PDT
Created attachment 102002 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-26 08:12:54 PDT
Comment on attachment 102002 [details]
Patch

Attachment 102002 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9250393

New failing tests:
http/tests/inspector/network/network-disable-cache-memory.html
http/tests/inspector/network/network-disable-cache-xhrs.html
Comment 3 Vsevolod Vlasov 2011-07-27 02:42:09 PDT
Created attachment 102111 [details]
Patch
Comment 4 Vsevolod Vlasov 2011-07-27 11:30:44 PDT
Committed r91858: <http://trac.webkit.org/changeset/91858>