Bug 65181 - Pass on the suggested filename to the chromium client
Summary: Pass on the suggested filename to the chromium client
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 07:28 PDT by Sadrul Habib Chowdhury
Modified: 2011-07-27 08:36 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.57 KB, patch)
2011-07-26 07:30 PDT, Sadrul Habib Chowdhury
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sadrul Habib Chowdhury 2011-07-26 07:28:20 PDT
The suggested filename in a@download (added in https://bugs.webkit.org/show_bug.cgi?id=64580) is not yet used in any platform. With this patch, the suggested filename is sent to the chromium client.
Comment 1 Sadrul Habib Chowdhury 2011-07-26 07:30:11 PDT
Created attachment 102000 [details]
patch

Not ready for review yet; the parent CLs need to go in first:

https://bugs.webkit.org/show_bug.cgi?id=64580
http://codereview.chromium.org/7484061/
Comment 2 Alexey Proskuryakov 2011-07-26 12:17:03 PDT
One comment about naming. In WebKit, "suggested file name" is what comes from the network loader, which builds it from data in Content-Disposition and Content-Type headers. Perhaps a different name can be used here to reduce confusion.
Comment 3 Darin Fisher (:fishd, Google) 2011-07-26 13:35:47 PDT
I like the use of suggestedName here.  It makes this variable nicely self-documenting.  "Start a download of this URL with this suggested name."  I think it is good that it correlate to the C-D header too.

Alexey, I'm not sure why you find this confusing.
Comment 4 Sadrul Habib Chowdhury 2011-07-26 17:41:02 PDT
Comment on attachment 102000 [details]
patch

Requesting cq? since the parent patch has landed.
Comment 5 Sadrul Habib Chowdhury 2011-07-26 17:54:42 PDT
(In reply to comment #4)
> (From update of attachment 102000 [details])
> Requesting cq? since the parent patch has landed.

Actually, that revision (r91797) probably needs to get rolled into the chromium tree first. I will ping here when that happens.
Comment 6 Sadrul Habib Chowdhury 2011-07-27 05:13:39 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 102000 [details] [details])
> > Requesting cq? since the parent patch has landed.
> 
> Actually, that revision (r91797) probably needs to get rolled into the chromium tree first. I will ping here when that happens.

r91797 has been rolled into chromium trunk. cq?
Comment 7 WebKit Review Bot 2011-07-27 08:36:44 PDT
Comment on attachment 102000 [details]
patch

Clearing flags on attachment: 102000

Committed r91847: <http://trac.webkit.org/changeset/91847>
Comment 8 WebKit Review Bot 2011-07-27 08:36:49 PDT
All reviewed patches have been landed.  Closing bug.