Bug 65170 - [Qt] Fix tst_QWebFrame::connectAndDisconnect() API test
Summary: [Qt] Fix tst_QWebFrame::connectAndDisconnect() API test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 38654
  Show dependency treegraph
 
Reported: 2011-07-26 04:17 PDT by Kristóf Kosztyó
Modified: 2012-11-14 04:37 PST (History)
2 users (show)

See Also:


Attachments
mark failing test cases as expected fail (3.77 KB, patch)
2011-08-02 05:07 PDT, Kristóf Kosztyó
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2011-07-26 04:17:51 PDT
FAIL!  : tst_QWebFrame::connectAndDisconnect() Compared values are not the same
   Actual (evalJS("slotThisObject == window")): false
   Expected (sTrue): true
   Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1455)]

It started failing after r91095
Comment 1 Kristóf Kosztyó 2011-07-29 03:58:31 PDT
this testcases also fail

FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1563)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist 
FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1572)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist 
FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1581)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist 
FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(123)")): 123 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1591)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist
FAIL! : tst_QWebFrame::connectAndDisconnect() Compared values are not the same Actual (evalJS("myObject.mySignalWithIntArg(456)")): 456 Expected (sUndefined): undefined Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1600)] QDEBUG : tst_QWebFrame::classEnums() can't make "generic.orientation" because no QAccelerometer sensors exist
Comment 2 Csaba Osztrogonác 2011-08-02 01:53:55 PDT
Could you mark them as expected fails?
Comment 3 Kristóf Kosztyó 2011-08-02 05:07:05 PDT
Created attachment 102634 [details]
mark failing test cases as expected fail
Comment 4 Csaba Osztrogonác 2011-08-02 05:11:46 PDT
Comment on attachment 102634 [details]
mark failing test cases as expected fail 

r=me
Comment 5 Csaba Osztrogonác 2011-08-02 05:14:56 PDT
Comment on attachment 102634 [details]
mark failing test cases as expected fail 

Landed in https://trac.webkit.org/changeset/92180
Comment 6 Csaba Osztrogonác 2012-11-14 04:37:17 PST
Tests were unskipped long time ago, so it is fixed.