NEW 65168
Use AtomicString in Document::documentNamedItems and Document::windowNamedItems 
https://bugs.webkit.org/show_bug.cgi?id=65168
Summary Use AtomicString in Document::documentNamedItems and Document::windowNamedItems
Patrick R. Gansterer
Reported 2011-07-26 02:31:07 PDT
Use AtomicString in Document::documentNamedItems and Document::windowNamedItems
Attachments
Patch (3.85 KB, patch)
2011-07-26 03:30 PDT, Patrick R. Gansterer 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-07-26 03:30:57 PDT
Created attachment 101983 [details] Patch
Ryosuke Niwa
Comment 2 2011-09-14 21:33:54 PDT
Comment on attachment 101983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101983&action=review looks sane to me. > Source/WebCore/dom/Document.cpp:4152 > return HTMLNameCollection::create(this, WindowNamedItems, name); But HTMLNameCollection::create takes const String!
Brent Fulgham
Comment 3 2011-11-10 09:44:27 PST
Comment on attachment 101983 [details] Patch For this patch to be useful, doesn't HTMLNameCollection::m_name need to be an AtomicString as well?
Eric Seidel (no email)
Comment 4 2012-03-01 13:56:55 PST
Comment on attachment 101983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101983&action=review >> Source/WebCore/dom/Document.cpp:4152 >> return HTMLNameCollection::create(this, WindowNamedItems, name); > > But HTMLNameCollection::create takes const String! That doesn't make the change completely invalid, but w/o some sort of microbenchmark to demonstrate that this is a win, this isn't worth doing w/o the AtomicStirng being kept around.
Note You need to log in before you can comment on or make changes to this bug.