Bug 65166 - [Chromium][DRT] MockSpellCheck.cpp should be clang clean
Summary: [Chromium][DRT] MockSpellCheck.cpp should be clang clean
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 23:10 PDT by Hajime Morrita
Modified: 2011-07-26 00:17 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2011-07-25 23:13 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-07-25 23:10:22 PDT
Asan enabled build complains as following:

third_party/WebKit/Tools/DumpRenderTree/chromium/MockSpellCheck.cpp:78:36: error: operands of ? are integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare]
    int wordLength = wordEnd == -1 ? stringText.length() - wordOffset : wordEnd - wordOffset;
                                   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~
Comment 1 Hajime Morrita 2011-07-25 23:13:38 PDT
Created attachment 101973 [details]
Patch
Comment 2 Hajime Morrita 2011-07-25 23:15:28 PDT
Comment on attachment 101973 [details]
Patch

Kent-san, could you take a look at this one line change?
Comment 3 Kent Tamura 2011-07-25 23:16:46 PDT
Comment on attachment 101973 [details]
Patch

ok
Comment 4 WebKit Review Bot 2011-07-26 00:17:37 PDT
Comment on attachment 101973 [details]
Patch

Clearing flags on attachment: 101973

Committed r91745: <http://trac.webkit.org/changeset/91745>
Comment 5 WebKit Review Bot 2011-07-26 00:17:41 PDT
All reviewed patches have been landed.  Closing bug.