RESOLVED FIXED65160
DFG non-speculative JIT emits inefficient code for arithmetic involving two registers 
https://bugs.webkit.org/show_bug.cgi?id=65160
Summary DFG non-speculative JIT emits inefficient code for arithmetic involving two r...
Filip Pizlo
Reported 2011-07-25 20:06:36 PDT
The DFG non-speculative JIT emits code for arithmetic that uses C helper functions in case the operands are not integers. This results in bad performance regressions in case of speculation failure, where the hot code involves arithmetic on doubles. The DFG non-speculative JIT should inline double arithmetic whenever possible, much like the old JSC JIT did.
Attachments
the patch (6.39 KB, patch)
2011-07-25 20:11 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-07-25 20:11:50 PDT
Created attachment 101964 [details] the patch Tests are still running; will change flags to ? when/if they pass.
Filip Pizlo
Comment 2 2011-07-25 20:15:43 PDT
Comment on attachment 101964 [details] the patch Tests passed, ready for review.
Gavin Barraclough
Comment 3 2011-07-25 22:25:19 PDT
Comment on attachment 101964 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=101964&action=review > Source/JavaScriptCore/ChangeLog:11 > + (albeit a small one), and a large speed-up on Kraken. We should start listing the magnitude of performance progressions in the ChangeLog. Failure to do so is making Sam sad. ;-)
WebKit Review Bot
Comment 4 2011-07-25 22:35:13 PDT
Comment on attachment 101964 [details] the patch Clearing flags on attachment: 101964 Committed r91743: <http://trac.webkit.org/changeset/91743>
WebKit Review Bot
Comment 5 2011-07-25 22:35:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.