Bug 65148 - Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
Summary: Add some debug logging to NRWT to diagnose why the windows bots can't determi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 16:08 PDT by Adam Barth
Modified: 2011-07-25 17:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2011-07-25 16:08 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-25 16:08:01 PDT 
Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
Comment 1 Adam Barth 2011-07-25 16:08:19 PDT 
Created attachment 101936 [details]
Patch
Comment 2 Adam Barth 2011-07-25 16:14:50 PDT 
Comment on attachment 101936 [details]
Patch

Clearing flags on attachment: 101936

Committed r91719: <http://trac.webkit.org/changeset/91719>
Comment 3 Adam Barth 2011-07-25 16:14:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ojan Vafai 2011-07-25 17:03:45 PDT 
We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code?
Comment 5 Adam Barth 2011-07-25 17:13:59 PDT 
> We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code?

Why does JSONResultsGenerator have it's own secret version of _get_svn_revision ?  :(
Comment 6 Adam Barth 2011-07-25 17:19:04 PDT 
Here's the log:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/5169/steps/webkit_tests/logs/stdio

2011-07-25 17:18:12,144 464 manager.py:221 DEBUG Failed to learn head_svn_revision:
2011-07-25 17:18:12,144 464 manager.py:222 DEBUG [Error 2] The system cannot find the file specified
Comment 7 Adam Barth 2011-07-25 17:30:36 PDT 
Attempt to fix in https://bugs.webkit.org/show_bug.cgi?id=65156
Comment 8 Ojan Vafai 2011-07-25 17:36:26 PDT 
(In reply to comment #5)
> > We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code?
> 
> Why does JSONResultsGenerator have it's own secret version of _get_svn_revision ?  :(

I've mentioned this code a billion times to Eric everytime he's tried fixing this bug.  This code was written before scm.py existed. An attempt to use scm.py's was made, but didn't work on windows so it was rolled back. :) Noone had time to look into why. See the FIXME above the code explaining all this.
Comment 9 Adam Barth 2011-07-25 17:53:11 PDT 
Well, hopefully the fix in Bug 65156 will fix windows and then we can delete this second implementation.