Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
Created attachment 101936 [details] Patch
Comment on attachment 101936 [details] Patch Clearing flags on attachment: 101936 Committed r91719: <http://trac.webkit.org/changeset/91719>
All reviewed patches have been landed. Closing bug.
We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code?
> We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code? Why does JSONResultsGenerator have it's own secret version of _get_svn_revision ? :(
Here's the log: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/5169/steps/webkit_tests/logs/stdio 2011-07-25 17:18:12,144 464 manager.py:221 DEBUG Failed to learn head_svn_revision: 2011-07-25 17:18:12,144 464 manager.py:222 DEBUG [Error 2] The system cannot find the file specified
Attempt to fix in https://bugs.webkit.org/show_bug.cgi?id=65156
(In reply to comment #5) > > We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code? > > Why does JSONResultsGenerator have it's own secret version of _get_svn_revision ? :( I've mentioned this code a billion times to Eric everytime he's tried fixing this bug. This code was written before scm.py existed. An attempt to use scm.py's was made, but didn't work on windows so it was rolled back. :) Noone had time to look into why. See the FIXME above the code explaining all this.
Well, hopefully the fix in Bug 65156 will fix windows and then we can delete this second implementation.