Bug 65145 – SVG and HTML editing have conflicting inline isWhitespace functions

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Darin Adler]

There is a function named isWhitespace in SVG and another in HTML Editing. Both are in the WebCore namespace, both are inline, but they have different contents.

[Dirk Schulze]

Thats correct. Do you want to rename one of the functions? What is the problem? As long as you do not include SVGParserUtills.h into headers it should work.

[Darin Adler]

(In reply to comment #1)
> Thats correct. Do you want to rename one of the functions?

Yes.

> What is the problem? As long as you do not include SVGParserUtills.h into headers it should work.

There are two problems:

    1) It's not good for us two have two different functions with the same name that do similar but different things. Even if these functions were guaranteed never to conflict, it's a recipe for confusion.

    1) Even though this currently works, it is not guaranteed to work. These functions are marked inline, but do not have internal linkage. The C++ standard does not allow two different functions with the same name with external linkage and different definitions. One thing that keeps this from being a practical problem right now is that the SVG function takes a const UChar& instead of a UChar so the functions are distinct. But that's actually a mistake. It's not good to have the function take a const UChar&.

I have a patch that fixes it by renaming the SVG parser utilities functions. I think you’ll probably like that patch.

[Darin Adler]

Created attachment 104273 [details]
Patch

[Nikolas Zimmermann]

Comment on attachment 104273 [details]
Patch

Looks reasonable, r=me.

[WebKit Review Bot]

Comment on attachment 104273 [details]
Patch

Clearing flags on attachment: 104273

Committed r93300: <http://trac.webkit.org/changeset/93300>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.