Bug 65143 - [chromium] components/mac: Make webcore not depend on CoreAnimation
Summary: [chromium] components/mac: Make webcore not depend on CoreAnimation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 15:50 PDT by Nico Weber
Modified: 2011-07-25 18:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2011-07-25 15:51 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2011-07-25 16:05 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2011-07-25 16:08 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2011-07-25 16:13 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch for landing (1.57 KB, patch)
2011-07-25 16:14 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-07-25 15:50:35 PDT 
[chromium] components/mac: Make webcore not depend on CoreAnimation
Comment 1 Nico Weber 2011-07-25 15:51:58 PDT 
Created attachment 101932 [details]
Patch
Comment 2 James Robinson 2011-07-25 15:55:09 PDT 
Comment on attachment 101932 [details]
Patch

Instead of #if 0 can you just delete these lines?
Comment 3 Sailesh Agrawal 2011-07-25 15:56:28 PDT 
(In reply to comment #2)
> (From update of attachment 101932 [details])
> Instead of #if 0 can you just delete these lines?

Deleting the code makes it harder to merge with ScrollAnimatorMac.mm
Comment 4 James Robinson 2011-07-25 15:57:50 PDT 
#ifdef !PLATFORM(CHROMIUM), then, since that's what we will probably want once we merge.
Comment 5 Nico Weber 2011-07-25 16:05:14 PDT 
Created attachment 101935 [details]
Patch
Comment 6 James Robinson 2011-07-25 16:07:23 PDT 
Comment on attachment 101935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101935&action=review

Thanks, that's better.  R=me.

When's the merge coming, btw?

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You have to delete or edits this line before trying to check in, it'll fail an svn presubmit hook.
Comment 7 Nico Weber 2011-07-25 16:08:54 PDT 
Created attachment 101937 [details]
Patch
Comment 8 Nico Weber 2011-07-25 16:11:08 PDT 
(In reply to comment #6)
> (From update of attachment 101935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101935&action=review
> 
> Thanks, that's better.  R=me.
> 
> When's the merge coming, btw?

sail: ^

> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> You have to delete or edits this line before trying to check in, it'll fail an svn presubmit hook.
Comment 9 Nico Weber 2011-07-25 16:13:40 PDT 
Created attachment 101939 [details]
Patch
Comment 10 Nico Weber 2011-07-25 16:14:36 PDT 
Created attachment 101940 [details]
Patch for landing
Comment 11 WebKit Review Bot 2011-07-25 18:04:50 PDT 
Comment on attachment 101940 [details]
Patch for landing

Clearing flags on attachment: 101940

Committed r91733: <http://trac.webkit.org/changeset/91733>
Comment 12 WebKit Review Bot 2011-07-25 18:04:55 PDT 
All reviewed patches have been landed.  Closing bug.