Bug 65143 – [chromium] components/mac: Make webcore not depend on CoreAnimation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

[chromium] components/mac: Make webcore not depend on CoreAnimation

[Nico Weber]

Created attachment 101932 [details]
Patch

[James Robinson]

Comment on attachment 101932 [details]
Patch

Instead of #if 0 can you just delete these lines?

[Sailesh Agrawal]

(In reply to comment #2)
> (From update of attachment 101932 [details])
> Instead of #if 0 can you just delete these lines?

Deleting the code makes it harder to merge with ScrollAnimatorMac.mm

[James Robinson]

#ifdef !PLATFORM(CHROMIUM), then, since that's what we will probably want once we merge.

[Nico Weber]

Created attachment 101935 [details]
Patch

[James Robinson]

Comment on attachment 101935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101935&action=review

Thanks, that's better.  R=me.

When's the merge coming, btw?

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You have to delete or edits this line before trying to check in, it'll fail an svn presubmit hook.

[Nico Weber]

Created attachment 101937 [details]
Patch

[Nico Weber]

(In reply to comment #6)
> (From update of attachment 101935 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101935&action=review
> 
> Thanks, that's better.  R=me.
> 
> When's the merge coming, btw?

sail: ^

> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> You have to delete or edits this line before trying to check in, it'll fail an svn presubmit hook.

[Nico Weber]

Created attachment 101939 [details]
Patch

[Nico Weber]

Created attachment 101940 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 101940 [details]
Patch for landing

Clearing flags on attachment: 101940

Committed r91733: <http://trac.webkit.org/changeset/91733>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.