Bug 65136 - simplify the UI of the header above the test list table
Summary: simplify the UI of the header above the test list table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 15:05 PDT by Ojan Vafai
Modified: 2011-07-25 15:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.46 KB, patch)
2011-07-25 15:07 PDT, Ojan Vafai 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-07-25 15:05:56 PDT 
simplify the UI of the header above the test list table
Comment 1 Ojan Vafai 2011-07-25 15:07:00 PDT 
Created attachment 101918 [details]
Patch
Comment 2 Adam Barth 2011-07-25 15:23:02 PDT 
Comment on attachment 101918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101918&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2346
> +    var isTrue = g_currentState[key];

isTrue ?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2347
> +    return '<label><input type=checkbox ' + (isTrue ? 'checked ' : '') + 'onclick="setQueryParameter(\'' + key + '\', ' + !isTrue + ')">' + text + '</label>';

/me advertises jQuery.  :)
Comment 3 Ojan Vafai 2011-07-25 15:32:52 PDT 
Committed r91711: <http://trac.webkit.org/changeset/91711>