Bug 65131 - [chromium] incorrect vertex shader used when rendering video layer
Summary: [chromium] incorrect vertex shader used when rendering video layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Critical
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 13:49 PDT by David Reveman
Modified: 2011-07-25 16:27 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.44 KB, patch)
2011-07-25 13:55 PDT, David Reveman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2011-07-25 13:49:51 PDT
CCVideoLayerImpl is currently using the same vertex program as the tiler. This program uses a 'point' uniform to generate vertex coordinates but CCVideoLayerImpl never sets this uniform.
Comment 1 David Reveman 2011-07-25 13:55:33 PDT
Created attachment 101904 [details]
Patch
Comment 2 James Robinson 2011-07-25 14:07:45 PDT
Comment on attachment 101904 [details]
Patch

OK.  We really should have some sort of test coverage to test this.
Comment 3 WebKit Review Bot 2011-07-25 16:27:41 PDT
Comment on attachment 101904 [details]
Patch

Clearing flags on attachment: 101904

Committed r91720: <http://trac.webkit.org/changeset/91720>
Comment 4 WebKit Review Bot 2011-07-25 16:27:46 PDT
All reviewed patches have been landed.  Closing bug.