RESOLVED FIXED65130
stop generating expectations.json now that it's unused 
https://bugs.webkit.org/show_bug.cgi?id=65130
Summary stop generating expectations.json now that it's unused
Ojan Vafai
Reported 2011-07-25 13:25:58 PDT
stop generating expectations.json now that it's unused
Attachments
Patch (8.28 KB, patch)
2011-07-25 13:27 PDT, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-07-25 13:27:03 PDT
Created attachment 101901 [details] Patch
Adam Barth
Comment 2 2011-07-25 13:39:10 PDT
Comment on attachment 101901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101901&action=review R++ > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:-782 > - return ExpectationsJsonEncoder(separators=(',', ':')).encode( > - self._all_expectations) Can we remove the whole ExpectationsJsonEncoder ?
Ojan Vafai
Comment 3 2011-07-25 13:43:34 PDT
Good point. In fact, we can now delete ModifiersAndExpectations, ExpectationsJsonEncoder and self._all_expectations (and related methods).
Ojan Vafai
Comment 4 2011-07-25 13:45:26 PDT
Committed r91704: <http://trac.webkit.org/changeset/91704>
Note You need to log in before you can comment on or make changes to this bug.