RESOLVED FIXED65127
by default hide tests that have passes for all recorded runs 
https://bugs.webkit.org/show_bug.cgi?id=65127
Summary by default hide tests that have passes for all recorded runs
Ojan Vafai
Reported 2011-07-25 13:04:09 PDT
by default hide tests that have passes for all recorded runs
Attachments
Patch (5.26 KB, patch)
2011-07-25 13:04 PDT, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-07-25 13:04:58 PDT
Created attachment 101897 [details] Patch
Adam Barth
Comment 2 2011-07-25 13:38:11 PDT
Comment on attachment 101897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360 > + for (var i = 0; i < tests.length; i++) > + html += open + tests[i].test + '</div>'; This line probably has XSS
Ojan Vafai
Comment 3 2011-07-25 14:01:27 PDT
(In reply to comment #2) > (From update of attachment 101897 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review > > > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360 > > + for (var i = 0; i < tests.length; i++) > > + html += open + tests[i].test + '</div>'; > > This line probably has XSS Yeah. There's a number of XSS holes in this code. There's not actually anything valuable at test-results.appspot.com though, so I'm loathe to spend the significant refactoring effort to fix these in cases where it's not trivial.
Ojan Vafai
Comment 4 2011-07-25 14:01:54 PDT
Committed r91705: <http://trac.webkit.org/changeset/91705>
Note You need to log in before you can comment on or make changes to this bug.