Bug 65127 - by default hide tests that have passes for all recorded runs
Summary: by default hide tests that have passes for all recorded runs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 13:04 PDT by Ojan Vafai
Modified: 2011-07-25 14:01 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.26 KB, patch)
2011-07-25 13:04 PDT, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-07-25 13:04:09 PDT
by default hide tests that have passes for all recorded runs
Comment 1 Ojan Vafai 2011-07-25 13:04:58 PDT
Created attachment 101897 [details]
Patch
Comment 2 Adam Barth 2011-07-25 13:38:11 PDT
Comment on attachment 101897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360
> +            for (var i = 0; i < tests.length; i++)
> +                html += open + tests[i].test + '</div>';

This line probably has XSS
Comment 3 Ojan Vafai 2011-07-25 14:01:27 PDT
(In reply to comment #2)
> (From update of attachment 101897 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review
> 
> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360
> > +            for (var i = 0; i < tests.length; i++)
> > +                html += open + tests[i].test + '</div>';
> 
> This line probably has XSS

Yeah. There's a number of XSS holes in this code. There's not actually anything valuable at test-results.appspot.com though, so I'm loathe to spend the significant refactoring effort to fix these in cases where it's not trivial.
Comment 4 Ojan Vafai 2011-07-25 14:01:54 PDT
Committed r91705: <http://trac.webkit.org/changeset/91705>