Bug 65114 - disable tests pending rebaseline with rotated text fix
Summary: disable tests pending rebaseline with rotated text fix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 08:50 PDT by Mike Reed
Modified: 2011-07-27 08:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.99 KB, patch)
2011-07-25 08:57 PDT, Mike Reed
no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2011-07-25 09:23 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-07-25 08:50:47 PDT
disable tests pending rebaseline with rotated text fix
Comment 1 Mike Reed 2011-07-25 08:57:25 PDT
Created attachment 101876 [details]
Patch
Comment 2 Stephen White 2011-07-25 09:20:03 PDT
Comment on attachment 101876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101876&action=review

> Source/WebCore/ChangeLog:11
> +        * platform/graphics/skia/ImageBufferSkia.cpp:
> +        (WebCore::getImageData):
> +        (WebCore::putImageData):
> +

Looks like this ChangeLog change is spurious.
Comment 3 Mike Reed 2011-07-25 09:23:16 PDT
Created attachment 101878 [details]
Patch
Comment 4 Mike Reed 2011-07-25 09:23:49 PDT
Comment on attachment 101878 [details]
Patch

indeed, removing spurious changelog
Comment 5 Stephen White 2011-07-25 09:47:41 PDT
Comment on attachment 101878 [details]
Patch

Looks good.
Comment 6 WebKit Review Bot 2011-07-25 10:47:44 PDT
Comment on attachment 101878 [details]
Patch

Clearing flags on attachment: 101878

Committed r91676: <http://trac.webkit.org/changeset/91676>
Comment 7 WebKit Review Bot 2011-07-25 10:47:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Mike Reed 2011-07-27 06:10:21 PDT
fix now enabled in chrome. these images should now be rebaselined.
Comment 9 Stephen White 2011-07-27 08:32:18 PDT
(In reply to comment #8)
> fix now enabled in chrome. these images should now be rebaselined.

Rebaselined in r91846.