Bug 65113 - Web Inspector: simplify Drawer.js
Summary: Web Inspector: simplify Drawer.js
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on: 68155
Blocks:
  Show dependency tree / graph
 
Reported: 2011-07-25 08:49 PDT by Yury Semikhatsky
Modified: 2011-09-21 05:06 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.36 KB, patch)
2011-07-25 08:51 PDT, Yury Semikhatsky 		pfeldman: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-07-25 08:49:54 PDT 
Drawer can only contain ConsoleView but contains some logic assuming that it can contain other type of views. The code can be simplified.
Comment 1 Yury Semikhatsky 2011-07-25 08:51:59 PDT 
Created attachment 101875 [details]
Patch
Comment 2 Pavel Feldman 2011-07-26 01:19:46 PDT 
Comment on attachment 101875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101875&action=review

> Source/WebCore/inspector/front-end/Drawer.js:59
> +        WebInspector.console.show();

Drawer class should not depend on console object unless they are merged into a single entity.