Bug 65112 – Web Inspector: Implement setPropertyValue using evaluate and callFunctionOn

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 101874 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 101874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101874&action=review

> LayoutTests/inspector/runtime/runtime-setPropertyValue.html:70
> +                InspectorTest.evaluateInPage("dumpObjects('Set undefined')", next);

You also need to test the case when setPropertyValue fails with an exception.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:206
> +            this.valueElement.addStyleClass("console-formatted-" + this.property.value.subtype);

Consider using <type>-<subtype> instead.

> Source/WebCore/inspector/front-end/RemoteObject.js:149
>              callback("Can't get a property of non-object.");

get -> set.

> Source/WebCore/inspector/front-end/RemoteObject.js:158
> +                callback(error || result);

What is the expected type of the callback parameter?

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 101874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101874&action=review
> 
> > LayoutTests/inspector/runtime/runtime-setPropertyValue.html:70
> > +                InspectorTest.evaluateInPage("dumpObjects('Set undefined')", next);
> 
> You also need to test the case when setPropertyValue fails with an exception.
> 

Done.

> > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:206
> > +            this.valueElement.addStyleClass("console-formatted-" + this.property.value.subtype);
> 
> Consider using <type>-<subtype> instead.
> 

I'd need to change it in too many places :(

> > Source/WebCore/inspector/front-end/RemoteObject.js:149
> >              callback("Can't get a property of non-object.");
> 
> get -> set.
> 

Done.

> > Source/WebCore/inspector/front-end/RemoteObject.js:158
> > +                callback(error || result);
> 
> What is the expected type of the callback parameter?

This is error message / error object.

[Pavel Feldman]

Created attachment 101880 [details]
Patch

[Pavel Feldman]

Created attachment 101881 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #3)
> > > Source/WebCore/inspector/front-end/RemoteObject.js:158
> > > +                callback(error || result);
> > 
> > What is the expected type of the callback parameter?
> 
> This is error message / error object.
Can we come up with something more definite here and say that the error is always an error object?

[Pavel Feldman]

Committed r91750: <http://trac.webkit.org/changeset/91750>