Bug 65110 - Web Inspector: use dedicated type for object id in the protocol.
Summary: Web Inspector: use dedicated type for object id in the protocol.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on: 65117
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-25 07:45 PDT by Pavel Feldman
Modified: 2011-07-26 09:16 PDT (History)
12 users (show)

See Also:


Attachments
Patch (16.16 KB, patch)
2011-07-25 07:51 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (16.94 KB, patch)
2011-07-25 08:07 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-07-25 07:45:54 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-07-25 07:51:46 PDT
Created attachment 101868 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-25 07:54:27 PDT
Attachment 101868 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InjectedScript.cpp:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.h:59:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yury Semikhatsky 2011-07-25 07:59:00 PDT
Comment on attachment 101868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101868&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:289
> +            args = JSON.parse(args);

JSON.parse may be overriden, use safe eval.

> Source/WebCore/inspector/InjectedScriptSource.js:304
> +                    return "Call argument should either contain object id or value property.";

Please add undefined argument handling.
Comment 4 Pavel Feldman 2011-07-25 08:07:56 PDT
Created attachment 101869 [details]
Patch
Comment 5 Pavel Feldman 2011-07-25 08:11:00 PDT
Committed r91668: <http://trac.webkit.org/changeset/91668>
Comment 6 Csaba Osztrogonác 2011-07-26 08:40:54 PDT
inspector/console/console-format.html fails after https://trac.webkit.org/changeset/91749 :
http://build.webkit.org/results/Qt%20Linux%20Release/r91750%20%2835770%29/inspector/console/console-format-pretty-diff.html

Could you check it, please?
Comment 7 Pavel Feldman 2011-07-26 09:16:54 PDT
(In reply to comment #6)
> inspector/console/console-format.html fails after https://trac.webkit.org/changeset/91749 :
> http://build.webkit.org/results/Qt%20Linux%20Release/r91750%20%2835770%29/inspector/console/console-format-pretty-diff.html
> 
> Could you check it, please?

Needs rebaseline. Moment.