Bug 65103 – Web Inspector: refactor remote object structure to contain value for primitive values.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 101864 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 101864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101864&action=review

> Source/WebCore/inspector/Inspector.json:226
> +                    { "name": "subtype", "type": "string", "optional": true, "enum": ["array", "null", "node", "undefined", "regexp", "date"], "description": "Object subtype hint. Specified for only for <code>object</code> type values only." },

There is undefined type.

> Source/WebCore/inspector/Inspector.json:227
> +                    { "name": "className", "type": "string", "optional": true, "description": "Object class (constructor) name. Specified for only for <code>object</code> type values only." },

Please leave only only.

> Source/WebCore/inspector/front-end/ConsoleView.js:852
> +            if (parameters[i] instanceof WebInspector.RemoteObject)

Please put a FIXME to extract this parameter conversion out of this method.

> Source/WebCore/inspector/front-end/RemoteObject.js:43
> +        this._hasChildren = false;

this._value = value?

[Pavel Feldman]

Committed r91665: <http://trac.webkit.org/changeset/91665>

[Csaba Osztrogonác]

inspector/console/console-format.html fails after https://trac.webkit.org/changeset/91749 :
http://build.webkit.org/results/Qt%20Linux%20Release/r91750%20%2835770%29/inspector/console/console-format-pretty-diff.html

Could you check it, please?