Bug 65103 - Web Inspector: refactor remote object structure to contain value for primitive values.
Summary: Web Inspector: refactor remote object structure to contain value for primitiv...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on: 65118
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-25 05:48 PDT by Pavel Feldman
Modified: 2011-07-26 08:40 PDT (History)
11 users (show)

See Also:


Attachments
Patch (27.32 KB, patch)
2011-07-25 05:51 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-07-25 05:48:49 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-07-25 05:51:47 PDT
Created attachment 101864 [details]
Patch
Comment 2 Yury Semikhatsky 2011-07-25 06:37:48 PDT
Comment on attachment 101864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101864&action=review

> Source/WebCore/inspector/Inspector.json:226
> +                    { "name": "subtype", "type": "string", "optional": true, "enum": ["array", "null", "node", "undefined", "regexp", "date"], "description": "Object subtype hint. Specified for only for <code>object</code> type values only." },

There is undefined type.

> Source/WebCore/inspector/Inspector.json:227
> +                    { "name": "className", "type": "string", "optional": true, "description": "Object class (constructor) name. Specified for only for <code>object</code> type values only." },

Please leave only only.

> Source/WebCore/inspector/front-end/ConsoleView.js:852
> +            if (parameters[i] instanceof WebInspector.RemoteObject)

Please put a FIXME to extract this parameter conversion out of this method.

> Source/WebCore/inspector/front-end/RemoteObject.js:43
> +        this._hasChildren = false;

this._value = value?
Comment 3 Pavel Feldman 2011-07-25 07:25:12 PDT
Committed r91665: <http://trac.webkit.org/changeset/91665>
Comment 4 Csaba Osztrogonác 2011-07-26 08:40:46 PDT
inspector/console/console-format.html fails after https://trac.webkit.org/changeset/91749 :
http://build.webkit.org/results/Qt%20Linux%20Release/r91750%20%2835770%29/inspector/console/console-format-pretty-diff.html

Could you check it, please?