Bug 65090 - Small cleanup of m_fontDirty tracking in CSSStyleSelector
Summary: Small cleanup of m_fontDirty tracking in CSSStyleSelector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-24 19:01 PDT by Luke Macpherson
Modified: 2011-07-24 22:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.84 KB, patch)
2011-07-24 19:07 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff
Patch for landing (8.23 KB, patch)
2011-07-24 21:12 PDT, Luke Macpherson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-07-24 19:01:21 PDT
Small cleanup of m_fontDirty tracking in CSSStyleSelector
Comment 1 Luke Macpherson 2011-07-24 19:07:06 PDT
Created attachment 101845 [details]
Patch
Comment 2 Darin Adler 2011-07-24 20:13:08 PDT
Comment on attachment 101845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101845&action=review

Please consider doing this without the name change.

> Source/WebCore/ChangeLog:8
> +        1) Use exising setFontDescription helper where appropriate.

Typo: existing

> Source/WebCore/css/CSSStyleSelector.cpp:1997
> -void CSSStyleSelector::updateFont()
> +void CSSStyleSelector::updateFontIfDirty()

I don’t think we need the name change. It’s great to move the check into the function, even without changing the function name to make that explicit.
Comment 3 Luke Macpherson 2011-07-24 21:12:30 PDT
Created attachment 101848 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-07-24 22:10:47 PDT
Comment on attachment 101848 [details]
Patch for landing

Clearing flags on attachment: 101848

Committed r91657: <http://trac.webkit.org/changeset/91657>
Comment 5 WebKit Review Bot 2011-07-24 22:10:51 PDT
All reviewed patches have been landed.  Closing bug.