Bug 65085 - Fix AtomicString vs. String usage in JSC binding
Summary: Fix AtomicString vs. String usage in JSC binding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 65172
  Show dependency treegraph
 
Reported: 2011-07-24 14:58 PDT by Patrick R. Gansterer
Modified: 2011-07-26 04:32 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2011-07-24 15:00 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-07-24 14:58:18 PDT
Fix AtomicString vs. String usage in JSC binding
Comment 1 Patrick R. Gansterer 2011-07-24 15:00:57 PDT
Created attachment 101834 [details]
Patch
Comment 2 Darin Adler 2011-07-24 17:35:50 PDT
Comment on attachment 101834 [details]
Patch

This change is great. Even better would be some way to catch such things at compile time. I’m tempted to suggest we make conversion from String to AtomicString an explicit function instead of an implicit constructor.
Comment 3 WebKit Review Bot 2011-07-24 18:27:19 PDT
Comment on attachment 101834 [details]
Patch

Clearing flags on attachment: 101834

Committed r91652: <http://trac.webkit.org/changeset/91652>
Comment 4 WebKit Review Bot 2011-07-24 18:27:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Patrick R. Gansterer 2011-07-24 20:50:15 PDT
(In reply to comment #2)
> (From update of attachment 101834 [details])
> This change is great. Even better would be some way to catch such things at compile time. I’m tempted to suggest we make conversion from String to AtomicString an explicit function instead of an implicit constructor.
I'm working on making the AtomicString(String) constructor explicit, but there are tooooo many errors at the moment.