Bug 65081 - Remove inclusion of MainThread.h from Threading.h
Summary: Remove inclusion of MainThread.h from Threading.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-24 11:40 PDT by Patrick R. Gansterer
Modified: 2011-07-30 21:46 PDT (History)
3 users (show)

See Also:


Attachments
Patch (60.80 KB, patch)
2011-07-24 11:45 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (62.03 KB, patch)
2011-07-24 13:04 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (62.54 KB, patch)
2011-07-24 13:45 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch for landing (63.03 KB, patch)
2011-07-30 03:21 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-07-24 11:40:34 PDT
Remove inclusion of MainThread.h from Threading.h
Comment 1 Patrick R. Gansterer 2011-07-24 11:45:52 PDT
Created attachment 101828 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-24 12:06:35 PDT
Comment on attachment 101828 [details]
Patch

Attachment 101828 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9234675
Comment 3 Darin Adler 2011-07-24 12:08:53 PDT
Comment on attachment 101828 [details]
Patch

Chromium build fails due to a file named CCLayerTreeHostImplProxy.cpp.
Comment 4 Patrick R. Gansterer 2011-07-24 13:04:26 PDT
Created attachment 101831 [details]
Patch
Comment 5 WebKit Review Bot 2011-07-24 13:35:32 PDT
Comment on attachment 101831 [details]
Patch

Attachment 101831 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9226774
Comment 6 Patrick R. Gansterer 2011-07-24 13:45:40 PDT
Created attachment 101832 [details]
Patch
Comment 7 WebKit Review Bot 2011-07-24 18:16:23 PDT
Comment on attachment 101832 [details]
Patch

Rejecting attachment 101832 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
dio/HRTFPanner.h:28,
                 from Source/WebCore/platform/audio/Panner.cpp:36:
Source/WebCore/webaudio/AudioContext.h: In member function 'void WebCore::AudioContext::incrementConnectionCount()':
Source/WebCore/webaudio/AudioContext.h:145: error: 'isMainThread' was not declared in this scope
make: *** [out/Debug/obj.target/webcore_platform/Source/WebCore/platform/audio/HRTFPanner.o] Error 1
make: *** [out/Debug/obj.target/webcore_platform/Source/WebCore/platform/audio/Panner.o] Error 1

Full output: http://queues.webkit.org/results/9228803
Comment 8 Patrick R. Gansterer 2011-07-30 03:21:09 PDT
Created attachment 102431 [details]
Patch for landing
Comment 9 WebKit Review Bot 2011-07-30 19:23:49 PDT
Comment on attachment 102431 [details]
Patch for landing

Clearing flags on attachment: 102431

Committed r92068: <http://trac.webkit.org/changeset/92068>
Comment 10 WebKit Review Bot 2011-07-30 19:23:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Adam Barth 2011-07-30 21:46:46 PDT
I cleaned up the run-bindings-tests results in http://trac.webkit.org/changeset/92069