Bug 65077 - [Qt] Lot of RenderTree mismatches in fast/multicol
Summary: [Qt] Lot of RenderTree mismatches in fast/multicol
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: LayoutTestFailure, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-07-24 07:56 PDT by Balazs Kelemen
Modified: 2011-07-25 06:31 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2011-07-24 07:56:41 PDT
Need to determine which ones need platform results and which ones are real failures.
Comment 1 Balazs Kelemen 2011-07-24 08:26:16 PDT
Added expected failures in http://trac.webkit.org/changeset/91645.
I think the one that has pixel result (fast/multicol/client-rects.html) looks totally wrong, the rest likely just need platform results. Ossy, could you take a look?
Comment 2 Balazs Kelemen 2011-07-24 13:58:03 PDT
Turn the skipping into orwt style to make all of our platforms happy: http://trac.webkit.org/changeset/91650 We should really switch to NRWT!
Comment 3 Csaba Osztrogonác 2011-07-25 05:49:51 PDT
Fix landed in https://trac.webkit.org/changeset/91662.

Balázs, feel free to fix NRWT for ARM, Qt 4.8 and wk2 if you would like to do the switch as soon as possible: https://bugs.webkit.org/show_bug.cgi?id=64071
Comment 4 Balazs Kelemen 2011-07-25 06:08:18 PDT
(In reply to comment #3)
> Fix landed in https://trac.webkit.org/changeset/91662.

Have you checked the client-rects test manually? In the expected png the boxes are in the center of the rectangular but with Qt they are outside of it. I don't think it is correct result :-)
Comment 5 Balazs Kelemen 2011-07-25 06:26:07 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Fix landed in https://trac.webkit.org/changeset/91662.
> 
> Have you checked the client-rects test manually? In the expected png the boxes are in the center of the rectangular but with Qt they are outside of it. I don't think it is correct result :-)

Nevermind, I had to use the test fonts.
Comment 6 Csaba Osztrogonác 2011-07-25 06:31:47 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Fix landed in https://trac.webkit.org/changeset/91662.
> 
> Have you checked the client-rects test manually? In the expected png the boxes are in the center of the rectangular but with Qt they are outside of it. I don't think it is correct result :-)

Of course. :) DRT generated correct results, but QtTestBrowser doesn't, because it doesn't use testfont by default. You can enable it with -use-test-fonts command line option.