Bug 65066 - Extract TestConfiguration from base and write a few unit tests to capture current behavior.
Summary: Extract TestConfiguration from base and write a few unit tests to capture cur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64385
  Show dependency treegraph
 
Reported: 2011-07-23 07:47 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-23 14:16 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.87 KB, patch)
2011-07-23 07:47 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-23 07:47:13 PDT
Extract TestConfiguration from base and write a few unit tests to capture current behavior.
Comment 1 Dimitri Glazkov (Google) 2011-07-23 07:47:55 PDT
Created attachment 101811 [details]
Patch
Comment 2 Adam Barth 2011-07-23 09:21:12 PDT
Comment on attachment 101811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101811&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:55
> +    def all_test_configurations(self):

@classmethod ?

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:70
> +    def all_systems(self):

@classmethod ?

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:79
> +    def all_build_types(self):

@classmethod ?

> Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:82
> +    def all_graphics_types(self):

@classmethod ?
Comment 3 Dimitri Glazkov (Google) 2011-07-23 13:18:51 PDT
(In reply to comment #2)
> (From update of attachment 101811 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101811&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:55
> > +    def all_test_configurations(self):
> 
> @classmethod ?

Yes.

> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:70
> > +    def all_systems(self):
> 
> @classmethod ?

Yes!

> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:79
> > +    def all_build_types(self):
> 
> @classmethod ?

Yes!!

> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:82
> > +    def all_graphics_types(self):
> 
> @classmethod ?

Oh, YES!!!
Comment 4 Dimitri Glazkov (Google) 2011-07-23 13:19:47 PDT
Comment on attachment 101811 [details]
Patch

Actually, these methods shouldn't be part of TestConfiguration at all. They would be port-dependent and should hang off the port object. I'll move them in a separate patch.
Comment 5 WebKit Review Bot 2011-07-23 14:16:45 PDT
Comment on attachment 101811 [details]
Patch

Clearing flags on attachment: 101811

Committed r91639: <http://trac.webkit.org/changeset/91639>
Comment 6 WebKit Review Bot 2011-07-23 14:16:50 PDT
All reviewed patches have been landed.  Closing bug.