RESOLVED FIXED 65066
Extract TestConfiguration from base and write a few unit tests to capture current behavior. 
https://bugs.webkit.org/show_bug.cgi?id=65066
Summary Extract TestConfiguration from base and write a few unit tests to capture cur...
Dimitri Glazkov (Google)
Reported 2011-07-23 07:47:13 PDT
Extract TestConfiguration from base and write a few unit tests to capture current behavior.
Attachments
Patch (11.87 KB, patch)
2011-07-23 07:47 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-23 07:47:55 PDT
Created attachment 101811 [details] Patch
Adam Barth
Comment 2 2011-07-23 09:21:12 PDT
Comment on attachment 101811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101811&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:55 > + def all_test_configurations(self): @classmethod ? > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:70 > + def all_systems(self): @classmethod ? > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:79 > + def all_build_types(self): @classmethod ? > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:82 > + def all_graphics_types(self): @classmethod ?
Dimitri Glazkov (Google)
Comment 3 2011-07-23 13:18:51 PDT
(In reply to comment #2) > (From update of attachment 101811 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101811&action=review > > > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:55 > > + def all_test_configurations(self): > > @classmethod ? Yes. > > > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:70 > > + def all_systems(self): > > @classmethod ? Yes! > > > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:79 > > + def all_build_types(self): > > @classmethod ? Yes!! > > > Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py:82 > > + def all_graphics_types(self): > > @classmethod ? Oh, YES!!!
Dimitri Glazkov (Google)
Comment 4 2011-07-23 13:19:47 PDT
Comment on attachment 101811 [details] Patch Actually, these methods shouldn't be part of TestConfiguration at all. They would be port-dependent and should hang off the port object. I'll move them in a separate patch.
WebKit Review Bot
Comment 5 2011-07-23 14:16:45 PDT
Comment on attachment 101811 [details] Patch Clearing flags on attachment: 101811 Committed r91639: <http://trac.webkit.org/changeset/91639>
WebKit Review Bot
Comment 6 2011-07-23 14:16:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.