Bug 65055 - [chromium] Remove code that attempted to explicitly sync compositing state before compositing
Summary: [chromium] Remove code that attempted to explicitly sync compositing state be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 16:11 PDT by James Robinson
Modified: 2011-07-22 16:38 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.35 KB, patch)
2011-07-22 16:15 PDT, James Robinson
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-07-22 16:11:20 PDT
[chromium] Remove code that attempted to explicitly sync compositing state before compositing
Comment 1 James Robinson 2011-07-22 16:15:01 PDT
Created attachment 101788 [details]
Patch
Comment 2 James Robinson 2011-07-22 16:15:45 PDT
I'd like to get this for m14.  Turns out this code is not useful like I hoped it would be and hurts framerate on some pages :(.
Comment 3 Kenneth Russell 2011-07-22 16:22:23 PDT
Comment on attachment 101788 [details]
Patch

This looks fine to me but testing is the only way to know whether this removal has any adverse side-effects.
Comment 4 James Robinson 2011-07-22 16:25:09 PDT
The layout tests and brief manual testing are happy, and we've added a lot of defensive code.  If I'm wrong I guess we'll find out via crash reports! Thanks for the prompt review.
Comment 5 James Robinson 2011-07-22 16:38:13 PDT
Committed r91621: <http://trac.webkit.org/changeset/91621>