Bug 65054 - pull test expectations into the dashboard from trac.webkit.org
Summary: pull test expectations into the dashboard from trac.webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 15:49 PDT by Ojan Vafai
Modified: 2011-07-22 18:34 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.93 KB, patch)
2011-07-22 15:51 PDT, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-07-22 15:49:26 PDT
pull test expectations into the dashboard from trac.webkit.org
Comment 1 Ojan Vafai 2011-07-22 15:51:16 PDT
Created attachment 101783 [details]
Patch
Comment 2 Adam Barth 2011-07-22 16:27:01 PDT
Comment on attachment 101783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101783&action=review

> Tools/TestResultServer/static-dashboards/dashboard_base.js:488
> +var CHROMIUM_EXPECTATIONS_URL = 'http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expectations.txt?format=txt';

You should probably use http://svn.webkit.org.  It's faster.
Comment 3 Ojan Vafai 2011-07-22 16:33:14 PDT
Committed r91620: <http://trac.webkit.org/changeset/91620>
Comment 4 Adam Roben (:aroben) 2011-07-22 18:21:15 PDT
Comment on attachment 101783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101783&action=review

>> Tools/TestResultServer/static-dashboards/dashboard_base.js:488
>> +var CHROMIUM_EXPECTATIONS_URL = 'http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium/test_expectations.txt?format=txt';
> 
> You should probably use http://svn.webkit.org.  It's faster.

Is it OK that we're always pulling from ToT? Do we need to pull from an older revision to match whatever revision was being tested?
Comment 5 Adam Barth 2011-07-22 18:34:27 PDT
Note: You can get whatever rev you want using the "r" or "p" URL parameter.