Bug 65053 - Switching off acceleration for small canvas broke gpu tests
Summary: Switching off acceleration for small canvas broke gpu tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alok Priyadarshi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 15:41 PDT by Alok Priyadarshi
Modified: 2011-07-23 11:45 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch (7.42 KB, patch)
2011-07-22 15:56 PDT, Alok Priyadarshi
no flags Details | Formatted Diff | Diff
proposed patch (9.63 KB, patch)
2011-07-22 16:08 PDT, Alok Priyadarshi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alok Priyadarshi 2011-07-22 15:41:27 PDT
Test expectations for gpu tests do not match if acceleration is switched off for small canvas. We should disable switching acceleration when testing so that we can have a consistent set of test expectations. This does not alter the test coverage because we already run canvas test for both hardware and software.

The tests got broken in: http://trac.webkit.org/changeset/91599
Comment 1 Alok Priyadarshi 2011-07-22 15:56:46 PDT
Created attachment 101785 [details]
proposed patch
Comment 2 James Robinson 2011-07-22 15:58:26 PDT
Comment on attachment 101785 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101785&action=review

At first glance, I think this is reasonable.  I'm curious what others think.

> Source/WebCore/page/Settings.h:364
> +        // Hardware acceleration is useful for large canvii where it can avoid the

nit: i think it's "canvases"
Comment 3 Alok Priyadarshi 2011-07-22 16:08:11 PDT
Created attachment 101786 [details]
proposed patch

The last patch had missing files. Verified that all canvas-related tests pass with this patch.
Comment 4 Alok Priyadarshi 2011-07-22 16:48:23 PDT
ping! GPU bots are red - this needs to be committed ASAP.

BTW there are also some unrelated regressions in GPU tests related to rotated layers and scrollbar rendering.
Comment 5 Brian Salomon 2011-07-22 21:05:03 PDT
I'm not very familiar with how these settings are managed but it looks reasonable.
Comment 6 Stephen White 2011-07-23 06:05:35 PDT
Comment on attachment 101786 [details]
proposed patch

Looks good.  r=me
Comment 7 WebKit Review Bot 2011-07-23 11:45:10 PDT
Comment on attachment 101786 [details]
proposed patch

Clearing flags on attachment: 101786

Committed r91638: <http://trac.webkit.org/changeset/91638>
Comment 8 WebKit Review Bot 2011-07-23 11:45:15 PDT
All reviewed patches have been landed.  Closing bug.