RESOLVED WONTFIX 65052
Make WebGraphicsContext3D::setParentContext pure virtual. 
https://bugs.webkit.org/show_bug.cgi?id=65052
Summary Make WebGraphicsContext3D::setParentContext pure virtual.
Al
Reported 2011-07-22 15:38:35 PDT
Make WebGraphicsContext3D::setParentContext pure virtual.
Attachments
Patch 1 (1.35 KB, patch)
2011-07-22 15:40 PDT, Al 		kbr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Al
Comment 1 2011-07-22 15:40:16 PDT
Created attachment 101781 [details] Patch 1
WebKit Review Bot
Comment 2 2011-07-22 15:42:23 PDT
Attachment 101781 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebGraphicsContext3D.h:135: The parameter name "parentContext" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Russell
Comment 3 2011-07-22 16:24:28 PDT
Comment on attachment 101781 [details] Patch 1 r- for style issue. Looks fine otherwise. There are some others that could also be made pure virtual. Maybe you would like to make them all pure in one patch?
Ahmad Saleem
Comment 4 2024-01-02 06:43:26 PST
It was for 'Chromium' port.
Note You need to log in before you can comment on or make changes to this bug.