Bug 65050 - Replace preprocessor statements in DOMWindow.idl with Conditional attribute
Summary: Replace preprocessor statements in DOMWindow.idl with Conditional attribute
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 65040 67427
Blocks: 67400
  Show dependency tree / graph
 
Reported: 2011-07-22 15:07 PDT by Patrick R. Gansterer
Modified: 2017-07-18 08:29 PDT (History)
5 users (show)

See Also:

Attachments
Patch (35.59 KB, patch)
2011-07-22 15:14 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (35.79 KB, patch)
2011-08-29 13:39 PDT, Patrick R. Gansterer 		gustavo.noronha: commit-queue-
Details | Formatted Diff | Diff
Patch (33.18 KB, patch)
2011-09-01 02:07 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (31.92 KB, patch)
2011-11-12 09:53 PST, Patrick R. Gansterer 		gustavo.noronha: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-07-22 15:07:53 PDT 
Replace preprocessor statements in DOMWindow.idl with Conditional attribute
Comment 1 Patrick R. Gansterer 2011-07-22 15:14:55 PDT 
Created attachment 101775 [details]
Patch
Comment 2 Gyuyoung Kim 2011-07-22 15:55:30 PDT 
Comment on attachment 101775 [details]
Patch

Attachment 101775 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9231225
Comment 3 Gustavo Noronha (kov) 2011-07-22 16:55:08 PDT 
Comment on attachment 101775 [details]
Patch

Attachment 101775 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9233220
Comment 4 Collabora GTK+ EWS bot 2011-07-22 17:02:29 PDT 
Comment on attachment 101775 [details]
Patch

Attachment 101775 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9232170
Comment 5 Brent Fulgham 2011-08-29 12:41:53 PDT 
Comment on attachment 101775 [details]
Patch

Looks good.  I like the uniform declarations with this approach; it's much clearer which features are needed for each IDL entry.
Comment 6 Patrick R. Gansterer 2011-08-29 13:39:51 PDT 
Created attachment 105517 [details]
Patch

bug 65050 is closed in the meantime, let's see if EWS is happy now
Comment 7 Collabora GTK+ EWS bot 2011-08-29 16:55:41 PDT 
Comment on attachment 105517 [details]
Patch

Attachment 105517 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9570080
Comment 8 Patrick R. Gansterer 2011-09-01 02:07:24 PDT 
Created attachment 105926 [details]
Patch
Comment 9 WebKit Review Bot 2011-09-01 03:23:16 PDT 
Comment on attachment 105926 [details]
Patch

Clearing flags on attachment: 105926

Committed r94284: <http://trac.webkit.org/changeset/94284>
Comment 10 WebKit Review Bot 2011-09-01 03:23:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Nico Weber 2011-09-01 12:10:52 PDT 
Comment on attachment 105926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105926&action=review

> Source/WebCore/page/DOMWindow.idl:-625
> -#if defined(ENABLE_SVG) && ENABLE_SVG

This breaks building without SVG enabled. Can you revert this part?
Comment 12 Patrick R. Gansterer 2011-09-01 12:50:57 PDT 
Reverted r94284 for reason:

Broke building without SVG enabled on Chromium.

Committed r94334: <http://trac.webkit.org/changeset/94334>
Comment 13 Patrick R. Gansterer 2011-11-12 09:53:43 PST 
Created attachment 114838 [details]
Patch
Comment 14 Collabora GTK+ EWS bot 2011-11-12 10:04:56 PST 
Comment on attachment 114838 [details]
Patch

Attachment 114838 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10449809