Bug 65043 - Remove support for GL_latch_CHROMIUM extension
Summary: Remove support for GL_latch_CHROMIUM extension
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Al
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 12:58 PDT by Al
Modified: 2011-07-25 18:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch 1 (13.00 KB, patch)
2011-07-22 13:02 PDT, Al
no flags Details | Formatted Diff | Diff
Patch 2 (14.57 KB, patch)
2011-07-22 14:04 PDT, Al
no flags Details | Formatted Diff | Diff
Fixed ChangeLog files. (14.60 KB, patch)
2011-07-25 17:47 PDT, Al
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Al 2011-07-22 12:58:47 PDT
Remove support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replace calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.
Comment 1 Al 2011-07-22 13:02:20 PDT
Created attachment 101757 [details]
Patch 1
Comment 2 James Robinson 2011-07-22 13:32:28 PDT
Comment on attachment 101757 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=101757&action=review

There's some code in Canvas2DLayerChromium.cpp that can be killed too - look for the big FIXME and the finish().

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:301
> +    if (hardwareCompositing())
> +        m_context->flush();

is this still needed? we'll do a swap on this context pretty soon
Comment 3 Al 2011-07-22 14:04:38 PDT
Created attachment 101761 [details]
Patch 2

Removing the flush of the compositor context and reducing the semantics from finish to flush appears to work.
Comment 4 James Robinson 2011-07-22 14:08:15 PDT
Comment on attachment 101761 [details]
Patch 2

Yay, I love deleting crappy old code.  This looks great to me!
Comment 5 WebKit Review Bot 2011-07-22 15:08:35 PDT
Comment on attachment 101761 [details]
Patch 2

Rejecting attachment 101761 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
343c65ab7287cd100d51f373ede4804b22981e70
r91606 = b372bde375ec9c1f739a022e36de1ae3199d7795
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9231213
Comment 6 Al 2011-07-25 17:47:37 PDT
Created attachment 101953 [details]
Fixed ChangeLog files.

Added "Reviewed by" lines to ChangLog files.
Comment 7 WebKit Review Bot 2011-07-25 18:18:20 PDT
Comment on attachment 101953 [details]
Fixed ChangeLog files.

Clearing flags on attachment: 101953

Committed r91736: <http://trac.webkit.org/changeset/91736>
Comment 8 WebKit Review Bot 2011-07-25 18:18:24 PDT
All reviewed patches have been landed.  Closing bug.