Bug 65043 – Remove support for GL_latch_CHROMIUM extension

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Al]

Remove support for the GL_latch_CHROMIUM extension which Chromium no longer supports.
Replace calls to SetLatch with calls to Flush since Flush now has barrier semantics in Chromium.

[Al]

Created attachment 101757 [details]
Patch 1

[James Robinson]

Comment on attachment 101757 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=101757&action=review

There's some code in Canvas2DLayerChromium.cpp that can be killed too - look for the big FIXME and the finish().

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:301
> +    if (hardwareCompositing())
> +        m_context->flush();

is this still needed? we'll do a swap on this context pretty soon

[Al]

Created attachment 101761 [details]
Patch 2

Removing the flush of the compositor context and reducing the semantics from finish to flush appears to work.

[James Robinson]

Comment on attachment 101761 [details]
Patch 2

Yay, I love deleting crappy old code.  This looks great to me!

[WebKit Review Bot]

Comment on attachment 101761 [details]
Patch 2

Rejecting attachment 101761 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
343c65ab7287cd100d51f373ede4804b22981e70
r91606 = b372bde375ec9c1f739a022e36de1ae3199d7795
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9231213

[Al]

Created attachment 101953 [details]
Fixed ChangeLog files.

Added "Reviewed by" lines to ChangLog files.

[WebKit Review Bot]

Comment on attachment 101953 [details]
Fixed ChangeLog files.

Clearing flags on attachment: 101953

Committed r91736: <http://trac.webkit.org/changeset/91736>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.