Bug 65032 - Improve (i.e., speed up) .gyp(i) files for Chromium
Summary: Improve (i.e., speed up) .gyp(i) files for Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 10:52 PDT by Viet-Trung Luu
Modified: 2011-07-26 12:37 PDT (History)
6 users (show)

See Also:


Attachments
Patch (54.91 KB, patch)
2011-07-22 10:58 PDT, Viet-Trung Luu
no flags Details | Formatted Diff | Diff
Patch (54.75 KB, patch)
2011-07-22 11:11 PDT, Viet-Trung Luu
no flags Details | Formatted Diff | Diff
Patch (106.39 KB, patch)
2011-07-22 11:30 PDT, Viet-Trung Luu
no flags Details | Formatted Diff | Diff
Patch (106.24 KB, patch)
2011-07-26 11:35 PDT, Viet-Trung Luu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viet-Trung Luu 2011-07-22 10:52:52 PDT
Improve (i.e., speed up) .gyp(i) files for Chromium
Comment 1 Viet-Trung Luu 2011-07-22 10:58:11 PDT
Created attachment 101741 [details]
Patch
Comment 2 Adam Barth 2011-07-22 11:04:56 PDT
Comment on attachment 101741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101741&action=review

> Source/WebCore/WebCore.gypi:6974
> +            # FIXME

?
Comment 3 WebKit Review Bot 2011-07-22 11:10:36 PDT
Comment on attachment 101741 [details]
Patch

Attachment 101741 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9230150
Comment 4 Viet-Trung Luu 2011-07-22 11:11:58 PDT
Created attachment 101742 [details]
Patch
Comment 5 Viet-Trung Luu 2011-07-22 11:12:30 PDT
(In reply to comment #2)
> (From update of attachment 101741 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101741&action=review
> 
> > Source/WebCore/WebCore.gypi:6974
> > +            # FIXME
> 
> ?

Oops, sorry about that.
Comment 6 WebKit Review Bot 2011-07-22 11:14:49 PDT
Comment on attachment 101742 [details]
Patch

Attachment 101742 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9233132
Comment 7 Viet-Trung Luu 2011-07-22 11:30:40 PDT
Created attachment 101745 [details]
Patch
Comment 8 WebKit Review Bot 2011-07-22 12:42:31 PDT
Comment on attachment 101745 [details]
Patch

Clearing flags on attachment: 101745

Committed r91595: <http://trac.webkit.org/changeset/91595>
Comment 9 WebKit Review Bot 2011-07-22 12:42:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Viet-Trung Luu 2011-07-26 11:35:43 PDT
Created attachment 102033 [details]
Patch
Comment 11 Viet-Trung Luu 2011-07-26 11:37:28 PDT
It was rolled out due to missing '../' in the source exclusion list for webcore_dom. Fixed now in new patch.
Comment 12 WebKit Review Bot 2011-07-26 12:37:14 PDT
Comment on attachment 102033 [details]
Patch

Clearing flags on attachment: 102033

Committed r91774: <http://trac.webkit.org/changeset/91774>
Comment 13 WebKit Review Bot 2011-07-26 12:37:21 PDT
All reviewed patches have been landed.  Closing bug.