%subj%
Created attachment 101712 [details] [patch] initial version
Comment on attachment 101712 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=101712&action=review > Source/WebCore/inspector/Inspector.json:1397 > + { "name": "maxJSCallStackDepth", "optional": true, "type": "integer" }, maxCallStackDepth missing description field: Samples JavaScript stack traces up to <code>maxCallStackDepth</code>, defaults to 5. > Source/WebCore/inspector/InspectorTimelineAgent.cpp:126 > + start(&error, &m_maxJSCallStackDepth); This value should be taken from the cookie.
Created attachment 101718 [details] [patch] second version
Comment on attachment 101718 [details] [patch] second version Clearing flags on attachment: 101718 Committed r91565: <http://trac.webkit.org/changeset/91565>
All reviewed patches have been landed. Closing bug.
Comment on attachment 101718 [details] [patch] second version View in context: https://bugs.webkit.org/attachment.cgi?id=101718&action=review > Source/WebCore/inspector/InspectorTimelineAgent.cpp:126 > + m_maxCallStackDepth = m_state->getLong(TimelineAgentState::timelineMaxCallStackDepth); Nit: you should assign value to a local variable here instead. "start" will handle the rest. Otherwise you violate the m_maxCallStackDepth encapsulation that limits its mutation to "start".