Bug 65023 - Web Inspector: the max depth of the Timeline events' stack trace should be customizable.
Summary: Web Inspector: the max depth of the Timeline events' stack trace should be cu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 04:45 PDT by Ilya Tikhonovsky
Modified: 2011-07-25 00:27 PDT (History)
10 users (show)

See Also:


Attachments
[patch] initial version (12.73 KB, patch)
2011-07-22 04:49 PDT, Ilya Tikhonovsky
pfeldman: review-
Details | Formatted Diff | Diff
[patch] second version (13.26 KB, patch)
2011-07-22 05:25 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-07-22 04:45:48 PDT
%subj%
Comment 1 Ilya Tikhonovsky 2011-07-22 04:49:06 PDT
Created attachment 101712 [details]
[patch] initial version
Comment 2 Pavel Feldman 2011-07-22 04:52:41 PDT
Comment on attachment 101712 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=101712&action=review

> Source/WebCore/inspector/Inspector.json:1397
> +                    { "name": "maxJSCallStackDepth", "optional": true, "type": "integer" },

maxCallStackDepth

missing description field: Samples JavaScript stack traces up to <code>maxCallStackDepth</code>, defaults to 5.

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:126
> +        start(&error, &m_maxJSCallStackDepth);

This value should be taken from the cookie.
Comment 3 Ilya Tikhonovsky 2011-07-22 05:25:43 PDT
Created attachment 101718 [details]
[patch] second version
Comment 4 Ilya Tikhonovsky 2011-07-22 06:38:16 PDT
Comment on attachment 101718 [details]
[patch] second version

Clearing flags on attachment: 101718

Committed r91565: <http://trac.webkit.org/changeset/91565>
Comment 5 Ilya Tikhonovsky 2011-07-22 06:38:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Pavel Feldman 2011-07-25 00:27:40 PDT
Comment on attachment 101718 [details]
[patch] second version

View in context: https://bugs.webkit.org/attachment.cgi?id=101718&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:126
> +        m_maxCallStackDepth = m_state->getLong(TimelineAgentState::timelineMaxCallStackDepth);

Nit: you should assign value to a local variable here instead. "start" will handle the rest. Otherwise you violate the m_maxCallStackDepth encapsulation that limits its mutation to "start".