Bug 65016 - Web Inspector: sometimes ReceiveResponse event is attached to wrong parent.
Summary: Web Inspector: sometimes ReceiveResponse event is attached to wrong parent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 00:58 PDT by Ilya Tikhonovsky
Modified: 2011-07-22 08:19 PDT (History)
10 users (show)

See Also:


Attachments
[patch] initial version (28.05 KB, patch)
2011-07-22 02:26 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] initial version with binary files. (61.51 KB, patch)
2011-07-22 02:30 PDT, Ilya Tikhonovsky
pfeldman: review-
Details | Formatted Diff | Diff
[patch] second version (47.15 KB, patch)
2011-07-22 05:41 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] third version (47.06 KB, patch)
2011-07-22 07:25 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-07-22 00:58:30 PDT
If resource load is forced by js then ReceiveResponse is attaching to FunctionCall event instead of SendRequest event.
Comment 1 Ilya Tikhonovsky 2011-07-22 02:26:06 PDT
Created attachment 101708 [details]
[patch] initial version
Comment 2 Ilya Tikhonovsky 2011-07-22 02:30:33 PDT
Created attachment 101709 [details]
[patch] initial version with binary files.
Comment 3 Pavel Feldman 2011-07-22 04:27:33 PDT
Comment on attachment 101709 [details]
[patch] initial version with binary files.

View in context: https://bugs.webkit.org/attachment.cgi?id=101709&action=review

> LayoutTests/inspector/timeline/timeline-receive-response-event-expected.txt:3
> +[

We should not dump internal objects with their implementation details
Comment 4 Ilya Tikhonovsky 2011-07-22 05:41:29 PDT
Created attachment 101720 [details]
[patch] second version
Comment 5 Yury Semikhatsky 2011-07-22 06:52:48 PDT
Comment on attachment 101720 [details]
[patch] second version

View in context: https://bugs.webkit.org/attachment.cgi?id=101720&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:417
> +            if (!newParentRecord && record.type === recordTypes.ResourceSendRequest)

Can you get rid of this condition?
Comment 6 Ilya Tikhonovsky 2011-07-22 07:25:33 PDT
Created attachment 101730 [details]
[patch] third version

comments addressed
Comment 7 Ilya Tikhonovsky 2011-07-22 08:19:26 PDT
Comment on attachment 101730 [details]
[patch] third version

Clearing flags on attachment: 101730

Committed r91567: <http://trac.webkit.org/changeset/91567>
Comment 8 Ilya Tikhonovsky 2011-07-22 08:19:35 PDT
All reviewed patches have been landed.  Closing bug.