RESOLVED FIXED 65007
[Qt] Add option to turn on disk caching in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=65007
Summary [Qt] Add option to turn on disk caching in QtTestBrowser
Keith Kyzivat
Reported 2011-07-21 19:52:41 PDT
Some of the tests that we run test the disk caching. While we're switching over to WK2, there is a desire to compare the results to WK1's QtTestBrowser. This is a request to add basic QNAM QNetworkDiskCache caching to QtTestBrowser.
Attachments
Patch (4.90 KB, patch)
2011-07-21 20:07 PDT, Keith Kyzivat
noam: review+
patch (4.77 KB, patch)
2011-07-22 08:23 PDT, Keith Kyzivat
no flags
Patch (5.24 KB, patch)
2011-07-25 14:03 PDT, Keith Kyzivat
no flags
Keith Kyzivat
Comment 1 2011-07-21 20:07:03 PDT
Noam Rosenthal
Comment 2 2011-07-22 01:05:15 PDT
Comment on attachment 101694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101694&action=review > Tools/QtTestBrowser/launcherwindow.cpp:808 > + qDebug() << "Using disk cache location: " << cacheLocation; > + cache->setCacheDirectory(cacheLocation); > + } > + page()->networkAccessManager()->setCache(cache); > + qDebug() << "disk cache" << (enable ? "enabled" : "disabled"); Please remove qDebug() before committing. Those tend to clutter after a while.
Keith Kyzivat
Comment 3 2011-07-22 08:23:17 PDT
WebKit Review Bot
Comment 4 2011-07-23 08:40:00 PDT
Comment on attachment 101734 [details] patch Clearing flags on attachment: 101734 Committed r91635: <http://trac.webkit.org/changeset/91635>
WebKit Review Bot
Comment 5 2011-07-23 08:40:04 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2011-07-24 12:53:53 PDT
Reopen, because it was rolled out by https://trac.webkit.org/changeset/91649 I rolled out this patch, because it broke the Qt minimal buildbot. Before you ask me, why I didn't try to fix it instead of rolling out: Because I won't do it instead of the author on a sunday night and the author must watch the buildbots on build.webkit.org and fix his patch if he break something.
Csaba Osztrogonác
Comment 7 2011-07-24 12:55:27 PDT
Keith Kyzivat
Comment 8 2011-07-24 13:12:18 PDT
Totally understandable Ossy. I'll fix it as soon as I get a chance to do a minimal build. How can I prevent this sort of situation from happening in the future? Is there an early warning bot that runs the minimal build configuration that I'm not aware of?
Csaba Osztrogonác
Comment 9 2011-07-25 07:16:06 PDT
(In reply to comment #8) > Totally understandable Ossy. I'll fix it as soon as I get a chance to do a minimal build. > > How can I prevent this sort of situation from happening in the future? Is there an early warning bot that runs the minimal build configuration that I'm not aware of? You can find the configuration of the minial bot here: http://build.webkit.org/buildslaves/szeged-linux-2 Unfortunately we don't have EWS bot for minimal build now, but it is a good idea.
Csaba Osztrogonác
Comment 10 2011-07-25 07:19:35 PDT
Eric, how can we add a new EWS platform for qt-minimal if we would like to do it?
Keith Kyzivat
Comment 11 2011-07-25 14:03:28 PDT
Created attachment 101906 [details] Patch patch updated to work with Qt minimal build
WebKit Review Bot
Comment 12 2011-07-26 18:13:02 PDT
Comment on attachment 101906 [details] Patch Clearing flags on attachment: 101906 Committed r91806: <http://trac.webkit.org/changeset/91806>
WebKit Review Bot
Comment 13 2011-07-26 18:13:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.