WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
65005
REGRESSION: A single line is split into two pages
https://bugs.webkit.org/show_bug.cgi?id=65005
Summary
REGRESSION: A single line is split into two pages
Kentaro Hara
Reported
2011-07-21 19:37:42 PDT
(1) Go to
http://haraken.info/null/print.html
(2) Print the page into pdf. What happens: The last line of each page can be split into the next page. This bug happens when the document width of a page is overflowed. Look at the page 5 or 6 of
http://haraken.info/null/print.pdf
I confirmed that this happens on Linux Chromium 14.0.828.0 and Mac Safari 5.0.5 with WebKit
r91443
. I found that this is the regression caused by WebKit
r88737
(
https://bugs.webkit.org/show_bug.cgi?id=61256
), which was the commit of mine. I would apologize for it. WebKit
r88737
tried to fix the rounding error in rendering calculations. However, I forgot to fix it for the cases where the document width gets overflowed. I am making a patch. See also
http://code.google.com/p/chromium/issues/detail?id=87828
Attachments
Patch
(277.00 KB, patch)
2011-07-21 21:55 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Patch
(277.06 KB, patch)
2011-08-02 00:40 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Patch
(277.39 KB, patch)
2011-08-19 00:37 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Patch
(278.71 KB, patch)
2011-08-19 01:58 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Patch
(277.33 KB, patch)
2011-08-19 03:18 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Rebased patch
(277.28 KB, patch)
2011-09-02 18:21 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Just see if the patch passes win
(276.41 KB, patch)
2011-09-12 01:11 PDT
,
Kentaro Hara
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
Just see if the patch passes win EWS
(276.47 KB, patch)
2011-09-12 04:13 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Just see if the patch passes win EWS
(276.43 KB, patch)
2011-09-12 16:50 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
patch for review
(277.75 KB, patch)
2011-09-12 18:37 PDT
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
Show Obsolete
(9)
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2011-07-21 21:55:28 PDT
Created
attachment 101697
[details]
Patch
Kentaro Hara
Comment 2
2011-07-25 16:36:54 PDT
Would you please take a look at the patch?
Kentaro Hara
Comment 3
2011-07-26 17:20:07 PDT
I confirmed that this problem also happens on Gtk. The problem can happen if the width of at least one line is overflowed.
Dominic Cooney
Comment 4
2011-07-31 18:41:47 PDT
Comment on
attachment 101697
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=101697&action=review
What is the reason for the failure on win?
> Source/WebCore/ChangeLog:19 > + * WebCore.exp.in: Added the signature of forceLayoutForPagination().
Added or updated?
> Source/WebCore/ChangeLog:21 > + (WebCore::Frame::setPrinting): Added a new argument |originalPageSize|, which is an original page size before being expanded or shrinked.
shrinked → shrunk
Kentaro Hara
Comment 5
2011-08-02 00:40:15 PDT
Created
attachment 102622
[details]
Patch
Kentaro Hara
Comment 6
2011-08-02 00:40:27 PDT
Comment on
attachment 101697
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=101697&action=review
>> Source/WebCore/ChangeLog:19 >> + * WebCore.exp.in: Added the signature of forceLayoutForPagination(). > > Added or updated?
Done.
>> Source/WebCore/ChangeLog:21 >> + (WebCore::Frame::setPrinting): Added a new argument |originalPageSize|, which is an original page size before being expanded or shrinked. > > shrinked → shrunk
Done.
Kentaro Hara
Comment 7
2011-08-19 00:37:52 PDT
Created
attachment 104472
[details]
Patch
Gyuyoung Kim
Comment 8
2011-08-19 00:48:42 PDT
Comment on
attachment 104472
[details]
Patch
Attachment 104472
[details]
did not pass efl-ews (efl): Output:
http://queues.webkit.org/results/9434138
WebKit Review Bot
Comment 9
2011-08-19 00:55:42 PDT
Comment on
attachment 104472
[details]
Patch
Attachment 104472
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/9435160
Gustavo Noronha (kov)
Comment 10
2011-08-19 00:58:33 PDT
Comment on
attachment 104472
[details]
Patch
Attachment 104472
[details]
did not pass gtk-ews (gtk): Output:
http://queues.webkit.org/results/9439141
Kentaro Hara
Comment 11
2011-08-19 01:58:00 PDT
Created
attachment 104477
[details]
Patch
Early Warning System Bot
Comment 12
2011-08-19 02:36:20 PDT
Comment on
attachment 104477
[details]
Patch
Attachment 104477
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/9433178
Kentaro Hara
Comment 13
2011-08-19 03:18:19 PDT
Created
attachment 104484
[details]
Patch
Kentaro Hara
Comment 14
2011-09-02 18:21:50 PDT
Created
attachment 106236
[details]
Rebased patch
Kentaro Hara
Comment 15
2011-09-12 01:11:56 PDT
Created
attachment 107028
[details]
Just see if the patch passes win
WebKit Review Bot
Comment 16
2011-09-12 01:50:40 PDT
Comment on
attachment 107028
[details]
Just see if the patch passes win
Attachment 107028
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/9635885
New failing tests: svg/custom/svg-fonts-word-spacing.html
Kentaro Hara
Comment 17
2011-09-12 04:13:07 PDT
Created
attachment 107038
[details]
Just see if the patch passes win EWS
Kentaro Hara
Comment 18
2011-09-12 16:50:29 PDT
Created
attachment 107113
[details]
Just see if the patch passes win EWS
Kentaro Hara
Comment 19
2011-09-12 18:37:43 PDT
Created
attachment 107124
[details]
patch for review
Dave Hyatt
Comment 20
2011-09-15 16:12:21 PDT
Comment on
attachment 107124
[details]
patch for review r=me
WebKit Review Bot
Comment 21
2011-09-15 18:16:46 PDT
Comment on
attachment 107124
[details]
patch for review Clearing flags on attachment: 107124 Committed
r95249
: <
http://trac.webkit.org/changeset/95249
>
WebKit Review Bot
Comment 22
2011-09-15 18:16:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug