REGRESSION: A single line is split into two pages

[Kentaro Hara]

(1) Go to http://haraken.info/null/print.html
(2) Print the page into pdf.

What happens: The last line of each page can be split into the next page. This bug happens when the document width of a page is overflowed. Look at the page 5 or 6 of http://haraken.info/null/print.pdf

I confirmed that this happens on Linux Chromium 14.0.828.0 and Mac Safari 5.0.5 with WebKit r91443. 

I found that this is the regression caused by WebKit r88737 (https://bugs.webkit.org/show_bug.cgi?id=61256), which was the commit of mine. I would apologize for it.  WebKit r88737 tried to fix the rounding error in rendering calculations. However, I forgot to fix it for the cases where the document width gets overflowed. I am making a patch. 

See also http://code.google.com/p/chromium/issues/detail?id=87828

[Kentaro Hara]

Created attachment 101697 [details]
Patch

[Kentaro Hara]

Would you please take a look at the patch?

[Kentaro Hara]

I confirmed that this problem also happens on Gtk. The problem can happen if the width of at least one line is overflowed.

[Dominic Cooney]

Comment on attachment 101697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101697&action=review

What is the reason for the failure on win?

> Source/WebCore/ChangeLog:19
> +        * WebCore.exp.in: Added the signature of forceLayoutForPagination().

Added or updated?

> Source/WebCore/ChangeLog:21
> +        (WebCore::Frame::setPrinting): Added a new argument |originalPageSize|, which is an original page size before being expanded or shrinked.

shrinked → shrunk

[Kentaro Hara]

Created attachment 102622 [details]
Patch

[Kentaro Hara]

Comment on attachment 101697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101697&action=review

>> Source/WebCore/ChangeLog:19
>> +        * WebCore.exp.in: Added the signature of forceLayoutForPagination().
> 
> Added or updated?

Done.

>> Source/WebCore/ChangeLog:21
>> +        (WebCore::Frame::setPrinting): Added a new argument |originalPageSize|, which is an original page size before being expanded or shrinked.
> 
> shrinked → shrunk

Done.

[Kentaro Hara]

Created attachment 104472 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 104472 [details]
Patch

Attachment 104472 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9434138

[WebKit Review Bot]

Comment on attachment 104472 [details]
Patch

Attachment 104472 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9435160

[Gustavo Noronha (kov)]

Comment on attachment 104472 [details]
Patch

Attachment 104472 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9439141

[Kentaro Hara]

Created attachment 104477 [details]
Patch

[Early Warning System Bot]

Comment on attachment 104477 [details]
Patch

Attachment 104477 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9433178

[Kentaro Hara]

Created attachment 104484 [details]
Patch

[Kentaro Hara]

Created attachment 106236 [details]
Rebased patch

[Kentaro Hara]

Created attachment 107028 [details]
Just see if the patch passes win

[WebKit Review Bot]

Comment on attachment 107028 [details]
Just see if the patch passes win

Attachment 107028 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9635885

New failing tests:
svg/custom/svg-fonts-word-spacing.html

[Kentaro Hara]

Created attachment 107038 [details]
Just see if the patch passes win EWS

[Kentaro Hara]

Created attachment 107113 [details]
Just see if the patch passes win EWS

[Kentaro Hara]

Created attachment 107124 [details]
patch for review

[Dave Hyatt]

Comment on attachment 107124 [details]
patch for review

r=me

[WebKit Review Bot]

Comment on attachment 107124 [details]
patch for review

Clearing flags on attachment: 107124

Committed r95249: <http://trac.webkit.org/changeset/95249>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.