Authentication does not work on Mac with USE(CFNETWORK) because my previous patches would create a new CFURLAuthChallengeRef. This mean that equality checks later in the code (and in CFNetwork) would fail.
Created attachment 101683 [details] Patch
Comment on attachment 101683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101683&action=review r=me > Source/WebCore/platform/network/mac/AuthenticationMac.mm:62 > + CFURLAuthChallengeRef m_cfChallenge; Should this be retained using a RetainPtr<CFURLAuthChallengeRef>?
(In reply to comment #2) > (From update of attachment 101683 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101683&action=review > > r=me Thanks! > > Source/WebCore/platform/network/mac/AuthenticationMac.mm:62 > > + CFURLAuthChallengeRef m_cfChallenge; > > Should this be retained using a RetainPtr<CFURLAuthChallengeRef>? I think we should be okay without the RetainPtr. The only one holding a reference to the WebCoreAuthenticationClientAsChallengeSender object is the NSURLAuthenticationChallenge object and if that goes away, there's no way to call core(NSURLAuthenticationChallenge *) method which accesses the m_cfChallenge ivar.
Committed r91554: <http://trac.webkit.org/changeset/91554>