Bug 65002 - Get authentication to work with USE(CFNETWORK) on Mac
Summary: Get authentication to work with USE(CFNETWORK) on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks: 51836
  Show dependency treegraph
 
Reported: 2011-07-21 18:13 PDT by Pratik Solanki
Modified: 2011-07-21 22:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.88 KB, patch)
2011-07-21 18:19 PDT, Pratik Solanki
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-07-21 18:13:57 PDT
Authentication does not work on Mac with USE(CFNETWORK) because my previous patches would create a new CFURLAuthChallengeRef. This mean that equality checks later in the code (and in CFNetwork) would fail.
Comment 1 Pratik Solanki 2011-07-21 18:19:57 PDT
Created attachment 101683 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2011-07-21 21:02:43 PDT
Comment on attachment 101683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101683&action=review

r=me

> Source/WebCore/platform/network/mac/AuthenticationMac.mm:62
> +    CFURLAuthChallengeRef m_cfChallenge;

Should this be retained using a RetainPtr<CFURLAuthChallengeRef>?
Comment 3 Pratik Solanki 2011-07-21 22:24:49 PDT
(In reply to comment #2)
> (From update of attachment 101683 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101683&action=review
> 
> r=me

Thanks!

> > Source/WebCore/platform/network/mac/AuthenticationMac.mm:62
> > +    CFURLAuthChallengeRef m_cfChallenge;
> 
> Should this be retained using a RetainPtr<CFURLAuthChallengeRef>?

I think we should be okay without the RetainPtr. The only one holding a reference to the WebCoreAuthenticationClientAsChallengeSender object is the NSURLAuthenticationChallenge object and if that goes away, there's no way to call core(NSURLAuthenticationChallenge *) method which accesses the m_cfChallenge ivar.
Comment 4 Pratik Solanki 2011-07-21 22:27:30 PDT
Committed r91554: <http://trac.webkit.org/changeset/91554>